Bugzilla – Attachment 123103 Details for
Bug 28728
Holds ratio page links to itself pointlessly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28728: Link to holds page from holds raio
Bug-28728-Link-to-holds-page-from-holds-raio.patch (text/plain), 2.61 KB, created by
Nick Clemens (kidclamp)
on 2021-07-23 12:07:13 UTC
(
hide
)
Description:
Bug 28728: Link to holds page from holds raio
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2021-07-23 12:07:13 UTC
Size:
2.61 KB
patch
obsolete
>From 6dac24b0ea984a8c30dc7628e889769c0e988b53 Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste-Henry <andrew@bywatersolutions.com> >Date: Wed, 21 Jul 2021 12:37:21 +0000 >Subject: [PATCH] Bug 28728: Link to holds page from holds raio > >To test: >1 - Find a bib with 1 item, place 3 bib-level holds on it (just to make > sure there's at least one title on your holds ratio page) >2 - Go to the holds ratio page in circulation >3 - mouse over the Holds Ratio column, see that the number there is a > link to http://[your koha]/cgi-bin/koha/circ/reserveratios.pl#, the > page you're already on >4 - apply patch, restart_all, reload page >5 - link now goes to the holds page for that title > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > .../intranet-tmpl/prog/en/modules/circ/reserveratios.tt | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt >index 6f049439ca..9f88b39591 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt >@@ -12,8 +12,6 @@ > <style> > .sql { display: none; } > .ulined { text-decoration: underline; } >- .ratiolimit:link { color: blue; cursor: pointer; } >- .ratiolimit:hover { color: blue; text-decoration: underline; } > #holdst ul li { list-style: outside url("[% interface | html %]/[% theme | html %]/img/item-bullet.gif") disc; } > </style> > </head> >@@ -70,7 +68,7 @@ > <tr> > <td><p>[% reserveloo.reservecount | html %]</p></td> > <td><p>[% reserveloo.itemcount | html %]</p></td> >- <td><a href="#" class="ratiolimit">[% reserveloo.thisratio | html %]</a></td> >+ <td><a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% reserveloo.biblionumber | uri %]" >[% reserveloo.thisratio | html %]</a></td> > <td> > [% INCLUDE 'biblio-title.inc' biblio=reserveloo link = 1 %][% IF ( reserveloo.author ) %] by [% reserveloo.author | html %][% END %] > </td> >@@ -195,10 +193,6 @@ > <script> > var columns_settings = [% TablesSettings.GetColumns( 'circ', 'holdsratios', 'holds-ratios', 'json' ) | $raw %]; > $(document).ready(function() { >- $(".ratiolimit").on("click", function(e) { >- e.preventDefault(); >- $("#ratio").val($(this).html()); >- }); > KohaTable("holdst", { > "aaSorting": [ [2,'desc'], [3,'asc'] ], > "aoColumnDefs": [ >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28728
:
123011
|
123096
| 123103