Attachment 123136 Details for Bug 28408 – Bug 28408: Add 'Last updated' column to suggestions table

[patch] Bug 28408: Add 'Last updated' column to suggestions table

Bug-28408-Add-Last-updated-column-to-suggestions-t.patch (text/plain), 3.01 KB, created by Kyle M Hall (khall) on 2021-07-23 14:50:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2021-07-23 14:50:40 UTC

Size: 3.01 KB

patch

obsolete

>From 787591b8adf6fa2e095d53580860a54725cca04c Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 28 May 2021 12:52:03 +0000
>Subject: [PATCH] Bug 28408: Add 'Last updated' column to suggestions table
>
>We have specific meanings for the different dates in suggestions
>Managed - means the status was changed or the suggestion edited, but doesn't change if item type updated
>Modification - implies an edit of the subscript, not updated if status changed alone
>Updated - this is the date field in the DB, which is actually a timestamp
>
>The cronjob purge_suggestions.pl uses teh 'date' field
>
>For a user, a suggestion can look old in the interface, but be considered recent by the script
>
>To clear the confusion we should show the timestamp as well
>
>To test:
>1 - Add a suggestion
>2 - In the DB, pretend you set it in the past:
>    UPDATE suggestions SET manageddate='2021-01-01', suggesteddate='2021-01-01', date='2021-01-01 12:12:12';
>3 - Click 'Go' In Organize by: Status
>4 - Note the suggestion looks old now
>5 - Check the box, and click 'Update item types with:' -> Submit
>6 - Prganize by status again
>7 - No change?
>8 - Check the DB:
>    SELECT date FROM suggestions;
>9 - The field is updated
>10 - Apply patch
>11 - Organize by status again
>12 - See the 'Last updated' ate set to today
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt    | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>index 5234d766a4..416623a846 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>@@ -733,6 +733,7 @@
>                                         <th>Managed on</th>
>                                         <th>Last modification by</th>
>                                         <th>Last modification on</th>
>+                                        <th>Last updated</th>
>                                         <th>Library</th>
>                                         <th>Fund</th>
>                                         <th>Status</th>
>@@ -800,6 +801,9 @@
>                                             <td data-order="[% suggestions_loo.lastmodificationdate | html %]">
>                                                 [% IF ( suggestions_loo.lastmodificationdate ) %][% suggestions_loo.lastmodificationdate | $KohaDates %][% END %]
>                                             </td>
>+                                            <td>
>+                                                [% suggestions_loo.date | $KohaDates %]
>+                                            </td>
>                                             <td>
>                                                 [% Branches.GetName( suggestions_loo.branchcode ) | html %]
>                                             </td>
>-- 
>2.30.1 (Apple Git-130)

Actions: View | Diff | Splinter Review

Attachments on bug 28408: 121482 | 121634 | 123136 | 123179