Attachment 123150 Details for Bug 28306 – Bug 28306: Fix POD

[patch] Bug 28306: Fix POD

Bug-28306-Fix-POD.patch (text/plain), 1.34 KB, created by Kyle M Hall (khall) on 2021-07-23 19:22:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2021-07-23 19:22:58 UTC

Size: 1.34 KB

patch

obsolete

>From 399ba379f62349ca42d311a6f5e27df2cc8f2601 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 23 Jul 2021 15:19:30 -0400
>Subject: [PATCH] Bug 28306: Fix POD
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> Koha/Database.pm | 21 +++++++++++++++++----
> 1 file changed, 17 insertions(+), 4 deletions(-)
>
>diff --git a/Koha/Database.pm b/Koha/Database.pm
>index 2dc5101a83..b976131155 100644
>--- a/Koha/Database.pm
>+++ b/Koha/Database.pm
>@@ -37,12 +37,25 @@ use Koha::Config;
> 
> our $database;
> 
>-# FIXME: It is useless to have a Koha::Database object since all methods
>-# below act as class methods
>-# Koha::Database->new->schema is exactly the same as Koha::Database->schema
>-# We should use Koha::Database->schema everywhere and remove the `new` method
>+=head2 new
>+
>+    $schema = Koha::Database->new->schema;
>+
>+    FIXME: It is useless to have a Koha::Database object since all methods
>+    below act as class methods
>+    Koha::Database->new->schema is exactly the same as Koha::Database->schema
>+    We should use Koha::Database->schema everywhere and remove the `new` method
>+
>+=cut
>+
> sub new { bless {}, shift }
> 
>+=head2 dbh
>+
>+    $dbh = Koha::Database->new->dbh;
>+
>+=cut
>+
> sub dbh {
>     my $config = Koha::Config->get_instance;
>     my $driver = db_scheme2dbi($config->get('db_scheme'));
>-- 
>2.30.1 (Apple Git-130)

Actions: View | Diff | Splinter Review

Attachments on bug 28306: 120752 | 120794 | 123145 | 123148 | 123149 | 123150 | 123151 | 124274 | 124282