Attachment 123159 Details for Bug 28679 – Bug 28679: Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled

[patch] Bug 28679: Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled

Bug-28679-Unable-to-click-Log-in-to-your-account-w.patch (text/plain), 2.48 KB, created by Katrin Fischer on 2021-07-24 22:44:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2021-07-24 22:44:24 UTC

Size: 2.48 KB

patch

obsolete

>From e92c354187ac8acc65d0fb1504033fa73fb8024b Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 12 Jul 2021 13:29:27 +0000
>Subject: [PATCH] Bug 28679: Unable to click "Log in to your account" when
> GoogleOpenIDConnect is enabled
>
>This patch corrects the login link in the OPAC when GoogleOpenIDConnect
>is enabled. It removes modal-related markup which was causing the link
>to fail.
>
>To test, apply the patch and enable the GoogleOpenIDConnect system
>preference.
>
>- In the OPAC, click the "Log in to your account" link in the header.
> You should be redirected to a Google authentication form.
>- Disable the GoogleOpenIDConnect preference. The login link in the OPAC
> should trigger a modal login form.
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>index e44ae2f111..40edbee41c 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>@@ -98,7 +98,7 @@
> [%# CAS authentication is too complicated for modal window %]
> <a class="nav-link login-link" href="/cgi-bin/koha/opac-user.pl"> Log in to your account</a>
> [% ELSIF ( Koha.Preference('GoogleOpenIDConnect') == 1 ) %]
>- <a class="nav-link login-link" href="/cgi-bin/koha/svc/auth/googleopenidconnect" role="button" data-toggle="modal"> Log in to your account</a>
>+ <a class="nav-link login-link" href="/cgi-bin/koha/svc/auth/googleopenidconnect"> Log in to your account</a>
> [% ELSE %]
> <a href="/cgi-bin/koha/opac-user.pl" class="nav-link login-link loginModal-trigger"> Log in to your account</a>
> [% END %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 28679: 122780 | 122928 | 123159