Bugzilla – Attachment 123249 Details for
Bug 28775
Warn when viewing itemtypes.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28775: Pass interface to getTranslatedLanguages
Bug-28775-Pass-interface-to-getTranslatedLanguages.patch (text/plain), 1.39 KB, created by
Nick Clemens (kidclamp)
on 2021-07-28 13:14:16 UTC
(
hide
)
Description:
Bug 28775: Pass interface to getTranslatedLanguages
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2021-07-28 13:14:16 UTC
Size:
1.39 KB
patch
obsolete
>From 7f72e35d98b27c2eb4d9ed69503264473a89ac1f Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 28 Jul 2021 13:12:03 +0000 >Subject: [PATCH] Bug 28775: Pass interface to getTranslatedLanguages > >Don't pass undef for interface, we are on the staff client > >To test: >1 - Browse to Administration -> Item types administration >2 - See in logs: > [WARN] Use of uninitialized value $interface in concatenation (.) or string at /kohadevbox/koha/C4/Languages.pm line 121. >3 - Apply patch >4 - Reload page >5 - No warn >--- > admin/itemtypes.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/admin/itemtypes.pl b/admin/itemtypes.pl >index 8652c3de9f..3624fe1049 100755 >--- a/admin/itemtypes.pl >+++ b/admin/itemtypes.pl >@@ -60,7 +60,7 @@ if ( $op eq 'add_form' ) { > my $parent_types = Koha::ItemTypes->search({parent_type=>undef,itemtype => {'!='=>$itemtype_code}}); > my $imagesets = C4::Koha::getImageSets( checked => ( $itemtype ? $itemtype->imageurl : undef ) ); > my $searchcategory = GetAuthorisedValues("ITEMTYPECAT"); >- my $translated_languages = C4::Languages::getTranslatedLanguages( undef , C4::Context->preference('template') ); >+ my $translated_languages = C4::Languages::getTranslatedLanguages( 'intranet' , C4::Context->preference('template') ); > $template->param( > itemtype => $itemtype, > parent_type => $parent_type, >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28775
:
123249
|
123345