Bugzilla – Attachment 123279 Details for
Bug 28057
Confusion of biblionumber and biblioitemnumber in request.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28057: (follow-up) Get the biblionumber column
Bug-28057-follow-up-Get-the-biblionumber-column.patch (text/plain), 1.54 KB, created by
Joonas Kylmälä
on 2021-07-29 09:31:49 UTC
(
hide
)
Description:
Bug 28057: (follow-up) Get the biblionumber column
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2021-07-29 09:31:49 UTC
Size:
1.54 KB
patch
obsolete
>From 217aea65cfbad25aa5ea10278169a64a2b71bcba Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 28 Jul 2021 17:37:46 +0000 >Subject: [PATCH] Bug 28057: (follow-up) Get the biblionumber column >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >When we fetch the biblioitems we use a select to limit the columns fetched, >we must include the biblionumber as well > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> >--- > reserve/request.pl | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index 1a027d26e2..00b7b6670f 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -421,7 +421,7 @@ foreach my $biblionumber (@biblionumbers) { > ( $biblioitem->{biblioitemnumber} => $biblioitem ) > } @{ Koha::Biblioitems->search( > { biblioitemnumber => { -in => \@biblioitemnumbers } }, >- { select => ['biblioitemnumber', 'publicationyear', 'itemtype']} >+ { select => ['biblionumber', 'biblioitemnumber', 'publicationyear', 'itemtype']} > )->unblessed > } > }; >@@ -459,7 +459,6 @@ foreach my $biblionumber (@biblionumbers) { > # it's complicated logic to analyse. > # (before this loop was inside that sub loop so it was O(n^2) ) > my $items_any_available; >- > $items_any_available = ItemsAnyAvailableAndNotRestricted( { biblionumber => $biblioitem->{biblionumber}, patron => $patron }) > if $patron; > >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28057
:
119598
|
123250
|
123266
|
123278
| 123279