Attachment 123333 Details for Bug 28495 – Bug 28495: (QA follow-up) Enable the use of underscores in branch codes

[patch] Bug 28495: (QA follow-up) Enable the use of underscores in branch codes

Bug-28495-QA-follow-up-Enable-the-use-of-underscor.patch (text/plain), 1.50 KB, created by Nick Clemens (kidclamp) on 2021-07-30 14:45:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-07-30 14:45:54 UTC

Size: 1.50 KB

patch

obsolete

>From 7699f2e82bcb1bc67a7bd4ad7134d3475c577817 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 30 Jul 2021 12:40:11 +0000
>Subject: [PATCH] Bug 28495: (QA follow-up) Enable the use of underscores in
> branch codes
>
>This patch adds underscores to the list of valid characters in the
>branch code field.
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>index 8ddda78da3..4b0c26840d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>@@ -329,13 +329,13 @@ Libraries &rsaquo; Administration &rsaquo; Koha
>     [% INCLUDE 'str/tinymce_i18n.inc' %]
>     <script>
>         jQuery.validator.addMethod( "letters_numbers", function(value,element){
>-            var patt = /^[a-zA-Z0-9]+$/g;
>+            var patt = /^[a-zA-Z0-9_]+$/g;
>             if (patt.test(element.value)) {
>                 return true;
>             } else {
>                 return false;
>             }
>-            }, _("Library code can only contain letters and numbers.")
>+            }, _("Library code can only contain letters, numbers, and underscores.")
>         );
> 
>         var columns_settings = [% TablesSettings.GetColumns( 'admin', 'libraries', 'libraries', 'json' ) | $raw %];
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28495: 121737 | 121867 | 123318 | 123332 | 123333