Bugzilla – Attachment 123342 Details for
Bug 22614
Request migration from one backend to another should not create new request
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22614: Migrate original request
Bug-22614-Migrate-original-request.patch (text/plain), 2.86 KB, created by
Nick Clemens (kidclamp)
on 2021-07-30 18:54:31 UTC
(
hide
)
Description:
Bug 22614: Migrate original request
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2021-07-30 18:54:31 UTC
Size:
2.86 KB
patch
obsolete
>From 9c1f27004c1de3bb9ebddcc9425c94aa92c70eea Mon Sep 17 00:00:00 2001 >From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> >Date: Mon, 1 Apr 2019 14:09:10 +0100 >Subject: [PATCH] Bug 22614: Migrate original request > >This patch changes an active request's backend and initiates the >migration on that request, rather than creating another and migrating >that. > >The majority of the work to accomplish this bug is being carried out in >the backends, since Koha delegates migrations to them. > >Signed-off-by: Barry Cannon <bc@interleaf.ie> >Signed-off-by: Assumpta Byrne <abyrne@ait.ie> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > Koha/Illrequest.pm | 3 ++- > Koha/Illrequest/Logger.pm | 4 ++++ > ill/ill-requests.pl | 6 ++---- > 3 files changed, 8 insertions(+), 5 deletions(-) > >diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm >index 6bcbaa7725..7ea301fde3 100644 >--- a/Koha/Illrequest.pm >+++ b/Koha/Illrequest.pm >@@ -718,7 +718,8 @@ Migrate a request from one backend to another. > > sub backend_migrate { > my ( $self, $params ) = @_; >- >+ # Set the request's backend to be the destination backend >+ $self->load_backend($params->{backend}); > my $response = $self->_backend_capability('migrate',{ > request => $self, > other => $params, >diff --git a/Koha/Illrequest/Logger.pm b/Koha/Illrequest/Logger.pm >index 2e7b1f09d7..31f1704446 100644 >--- a/Koha/Illrequest/Logger.pm >+++ b/Koha/Illrequest/Logger.pm >@@ -215,6 +215,10 @@ sub get_log_template { > } else { > # It's probably a backend log, so we need to get the path to the > # template from the backend >+ # >+ # We need to load the backend that this log was made from, so we >+ # can get the template >+ $params->{request}->load_backend($origin); > my $backend =$params->{request}->{_my_backend}; > return $backend->get_log_template_path($action); > } >diff --git a/ill/ill-requests.pl b/ill/ill-requests.pl >index fef5e550c7..6898e5b886 100755 >--- a/ill/ill-requests.pl >+++ b/ill/ill-requests.pl >@@ -152,14 +152,12 @@ if ( $backends_available ) { > my $request = Koha::Illrequests->find($params->{illrequest_id}); > my $backend_result; > if ( $params->{backend} ) { >- my $new_request = Koha::Illrequest->new->load_backend( $params->{backend} ); >- $backend_result = $new_request->backend_migrate($params); >+ $backend_result = $request->backend_migrate($params); > if ($backend_result) { > $template->param( > whole => $backend_result, >- request => $new_request >+ request => $request > ); >- $request = $new_request; > } else { > # Backend failure, redirect back to illview > print $cgi->redirect( '/cgi-bin/koha/ill/ill-requests.pl' >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22614
:
87277
|
87357
|
122645
| 123342