Attachment 123368 Details for Bug 26626 – Bug 26626: Add 'Ignore' option to confirmed holds modal

[patch] Bug 26626: Add 'Ignore' option to confirmed holds modal

Bug-26626-Add-Ignore-option-to-confirmed-holds-mod.patch (text/plain), 2.66 KB, created by Nick Clemens (kidclamp) on 2021-08-02 12:29:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-08-02 12:29:37 UTC

Size: 2.66 KB

patch

obsolete

>From a97fdae3a526e2f0a3a194fc1b71a3962ad9e416 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 2 Aug 2021 12:26:29 +0000
>Subject: [PATCH] Bug 26626: Add 'Ignore' option to confirmed holds modal
>
>This patch adds 'Ignore' to the 'Hold already waiting' modal
>
>To test:
>To recreate:
> 1 - Place a hold for pickup at library A
> 2 - Checkin the item at Library A
> 3 - Note the modal has 'Ignore' option
> 4 - Click it, nothing happens
> 5 - Check in the item again, same modal
> 6 - Click 'Confirm'
> 7 - Check in the item again
> 8 - Now 'Ignore' is replaced by 'Cancel'
> 9 - Click 'Confirm' to dismiss modal
>10 - Apply patch
>11 - Check the item in again
>12 - Note 'Ignore' button before 'Cancel' button with '-' icon
>13 - Go to biblio holds page
>14 - Revert waiting status
>15 - Check item in again
>16 - Note ignore now has '-' (minus) icon
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index eec665f6b1..a6bc55633c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -553,6 +553,9 @@
>                                                     <button type="button" class="btn btn-default print">
>                                                         <i class="fa fa-print"></i> Print slip and confirm
>                                                     </button>
>+                                                    <button data-dismiss="modal" aria-hidden="true" type="submit" class="btn btn-default deny">
>+                                                        <i class="fa fa-minus"></i> Ignore
>+                                                    </button>
> 
>                                                     <button type="button" class="btn btn-default deny cancel-hold">
>                                                         <i class="fa fa-times"></i> Cancel hold
>@@ -729,7 +732,7 @@
>                                                     [% END %]
> 
>                                                     <button data-dismiss="modal" aria-hidden="true" type="submit" class="btn btn-default deny">
>-                                                        <i class="fa fa-times"></i> Ignore
>+                                                        <i class="fa fa-minus"></i> Ignore
>                                                     </button>
>                                                 </div> 
>                                             </form> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26626: 123368 | 123373 | 123462 | 123698 | 123699 | 139470 | 139471 | 139472 | 139540 | 139541 | 139542