Attachment 123390 Details for Bug 24190 – Bug 24190: (follow-up) Rename AcqLog

[patch] Bug 24190: (follow-up) Rename AcqLog

Bug-24190-follow-up-Rename-AcqLog.patch (text/plain), 6.12 KB, created by Nick Clemens (kidclamp) on 2021-08-02 13:47:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-08-02 13:47:57 UTC

Size: 6.12 KB

patch

obsolete

>From 1ffd053df9ae235a2426c06e54f15650c4a1f8e1 Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Wed, 16 Jun 2021 14:27:30 +0100
>Subject: [PATCH] Bug 24190: (follow-up) Rename AcqLog
>
>As requested in comment #49, renamed uses of AcqLog to AcquisitionLog
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> C4/Budgets.pm            | 6 +++---
> acqui/addorder.pl        | 4 ++--
> acqui/cancelorder.pl     | 2 +-
> acqui/finishreceive.pl   | 2 +-
> acqui/invoice.pl         | 6 +++---
> admin/aqbudgetperiods.pl | 2 +-
> 6 files changed, 11 insertions(+), 11 deletions(-)
>
>diff --git a/C4/Budgets.pm b/C4/Budgets.pm
>index 8b6d63c7e5..9624650be1 100644
>--- a/C4/Budgets.pm
>+++ b/C4/Budgets.pm
>@@ -645,7 +645,7 @@ sub AddBudget {
>     my $id = $resultset->create($budget)->id;
> 
>     # Log the addition
>-    if (C4::Context->preference("AcqLog")) {
>+    if (C4::Context->preference("AcquisitionLog")) {
>         my $infos = {
>             budget_amount => $budget->{budget_amount},
>             budget_encumb => $budget->{budget_encumb},
>@@ -669,7 +669,7 @@ sub ModBudget {
>     return unless($result);
> 
>     # Log this modification
>-    if (C4::Context->preference("AcqLog")) {
>+    if (C4::Context->preference("AcquisitionLog")) {
>         my $infos = {
>             budget_amount_new    => $budget->{budget_amount},
>             budget_encumb_new    => $budget->{budget_encumb},
>@@ -701,7 +701,7 @@ sub DelBudget {
> 	my $sth         = $dbh->prepare("delete from aqbudgets where budget_id=?");
> 	my $rc          = $sth->execute($budget_id);
>     # Log the deletion
>-    if (C4::Context->preference("AcqLog")) {
>+    if (C4::Context->preference("AcquisitionLog")) {
>         logaction(
>             'ACQUISITIONS',
>             'DELETE_FUND',
>diff --git a/acqui/addorder.pl b/acqui/addorder.pl
>index dbfad999a1..e62cfe4710 100755
>--- a/acqui/addorder.pl
>+++ b/acqui/addorder.pl
>@@ -319,7 +319,7 @@ if ( $basket->{is_standing} || $orderinfo->{quantity} ne '0' ) {
>     if ( $orderinfo->{ordernumber} ) {
>         ModOrder($orderinfo);
>         # Log the order modification
>-        if (C4::Context->preference("AcqLog")) {
>+        if (C4::Context->preference("AcquisitionLog")) {
>             my $infos = {};
>             foreach my $field(@log_order_fields) {
>                 $infos->{$field} = $orderinfo->{$field};
>@@ -335,7 +335,7 @@ if ( $basket->{is_standing} || $orderinfo->{quantity} ne '0' ) {
>     else { # else, it's a new line
>         $order->store;
>         # Log the order creation
>-        if (C4::Context->preference("AcqLog")) {
>+        if (C4::Context->preference("AcquisitionLog")) {
>             my $infos = {};
>             foreach my $field(@log_order_fields) {
>                 $infos->{$field} = $orderinfo->{$field};
>diff --git a/acqui/cancelorder.pl b/acqui/cancelorder.pl
>index a0df47a866..b0eb8edb07 100755
>--- a/acqui/cancelorder.pl
>+++ b/acqui/cancelorder.pl
>@@ -66,7 +66,7 @@ if( $action and $action eq "confirmcancel" ) {
>             if $messages[0]->message eq 'error_delbiblio';
>     } else {
>         # Log the cancellation of the order
>-        if (C4::Context->preference("AcqLog")) {
>+        if (C4::Context->preference("AcquisitionLog")) {
>             logaction('ACQUISITIONS', 'CANCEL_ORDER', $ordernumber);
>         }
>         $template->param(success_cancelorder => 1);
>diff --git a/acqui/finishreceive.pl b/acqui/finishreceive.pl
>index 9934af6aa0..e37c91530e 100755
>--- a/acqui/finishreceive.pl
>+++ b/acqui/finishreceive.pl
>@@ -192,7 +192,7 @@ if ($suggestion_id) {
> }
> 
> # Log the receipt
>-if (C4::Context->preference("AcqLog")) {
>+if (C4::Context->preference("AcquisitionLog")) {
>     my $infos = {
>         quantityrec      => $quantityrec,
>         bookfund         => $bookfund,
>diff --git a/acqui/invoice.pl b/acqui/invoice.pl
>index 8e73e6dd63..91edfc435f 100755
>--- a/acqui/invoice.pl
>+++ b/acqui/invoice.pl
>@@ -148,7 +148,7 @@ elsif ( $op && $op eq 'del_adj' ) {
>     my $adjustment_id  = $input->param('adjustment_id');
>     my $del_adj = Koha::Acquisition::Invoice::Adjustments->find( $adjustment_id );
>     if ($del_adj) {
>-        if (C4::Context->preference("AcqLog")) {
>+        if (C4::Context->preference("AcquisitionLog")) {
>             my $infos = {
>                 invoiceid     => $del_adj->invoiceid,
>                 budget_id     => $del_adj->budget_id,
>@@ -194,7 +194,7 @@ elsif ( $op && $op eq 'mod_adj' ) {
>             my $new_adj = Koha::Acquisition::Invoice::Adjustment->new($adj);
>             $new_adj->store();
>             # Log this addition
>-            if (C4::Context->preference("AcqLog")) {
>+            if (C4::Context->preference("AcquisitionLog")) {
>                 logaction(
>                     'ACQUISITIONS',
>                     'CREATE_INVOICE_ADJUSTMENT',
>@@ -207,7 +207,7 @@ elsif ( $op && $op eq 'mod_adj' ) {
>             my $old_adj = Koha::Acquisition::Invoice::Adjustments->find( $adjustment_id[$i] );
>             unless ( $old_adj->adjustment == $adjustment[$i] && $old_adj->reason eq $reason[$i] && $old_adj->budget_id == $budget_id[$i] && $old_adj->encumber_open == $e_open{$adjustment_id[$i]} && $old_adj->note eq $note[$i] ){
>                 # Log this modification
>-                if (C4::Context->preference("AcqLog")) {
>+                if (C4::Context->preference("AcquisitionLog")) {
>                     my $infos = {
>                         adjustment        => $adjustment[$i],
>                         reason            => $reason[$i],
>diff --git a/admin/aqbudgetperiods.pl b/admin/aqbudgetperiods.pl
>index 091943acb3..71ede5dccb 100755
>--- a/admin/aqbudgetperiods.pl
>+++ b/admin/aqbudgetperiods.pl
>@@ -120,7 +120,7 @@ elsif ( $op eq 'add_validate' ) {
>         $$budget_period_hashref{$_}||=0 for qw(budget_period_active budget_period_locked);
>         my $status=ModBudgetPeriod($budget_period_hashref);
>         # Log the budget modification
>-        if (C4::Context->preference("AcqLog")) {
>+        if (C4::Context->preference("AcquisitionLog")) {
>             my $diff = 0 - ($budgetperiod_old->{budget_period_total} - $budget_period_hashref->{budget_period_total});
>             my $infos = {
>                 budget_period_startdate     => $input->param('budget_period_startdate'),
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24190: 96364 | 96369 | 100243 | 105082 | 105083 | 106096 | 106097 | 106098 | 106099 | 111080 | 111081 | 111082 | 111083 | 111084 | 112509 | 112510 | 112511 | 112512 | 112513 | 112514 | 116148 | 116149 | 116150 | 116151 | 116152 | 116153 | 122040 | 122041 | 122042 | 122043 | 122044 | 122045 | 123385 | 123386 | 123387 | 123388 | 123389 | 123390 | 123391 | 125119