Bugzilla – Attachment 123440 Details for
Bug 22435
Clarify account_offset types by converting them to clear codes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22435: (QA follow-up) Fix returned offsets in moredetail
Bug-22435-QA-follow-up-Fix-returned-offsets-in-mor.patch (text/plain), 1.75 KB, created by
Martin Renvoize (ashimema)
on 2021-08-03 14:34:39 UTC
(
hide
)
Description:
Bug 22435: (QA follow-up) Fix returned offsets in moredetail
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-08-03 14:34:39 UTC
Size:
1.75 KB
patch
obsolete
>From 4cb29ab31f56070da385d5dd1d1eb6f709d65cc1 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 21 Jun 2021 17:08:33 +0100 >Subject: [PATCH] Bug 22435: (QA follow-up) Fix returned offsets in moredetail > >This patch updates the offsets query for lost item returns displayed in >the catalogue/moredetail controller. > >Test plan (Same as bug 19919) >Test plan: >1) Pay off a LOST item >2) Check for the associated display of 'Paidfor?:' on the itemdetails page >3) Writeoff a LOST item >4) Check that a 'Paidfor?:' is not displayed on the itemdetails page. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > catalogue/moredetail.pl | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > >diff --git a/catalogue/moredetail.pl b/catalogue/moredetail.pl >index 38eab6aafa..e033a2105b 100755 >--- a/catalogue/moredetail.pl >+++ b/catalogue/moredetail.pl >@@ -208,14 +208,13 @@ foreach my $item (@items){ > ); > > if ( my $accountline = $accountlines->next ) { >- my $payment_offsets = Koha::Account::Offsets->search( >+ my $payment_offsets = $accountline->debit_offsets( > { >- debit_id => $accountline->id, > credit_id => { '!=' => undef }, # it is not the debit itself >- type => { '!=' => [ 'Writeoff', 'Forgiven' ] }, >- amount => { '<' => 0 } # credits are negative on the DB >+ 'credit.credit_type_code' => >+ { '!=' => [ 'Writeoff', 'Forgiven' ] }, > }, >- { order_by => { '-desc' => 'created_on' } } >+ { join => 'credit', order_by => { '-desc' => 'created_on' } } > ); > > if ($payment_offsets->count) { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22435
:
118340
|
118341
|
118541
|
118542
|
118543
|
118544
|
118545
|
118546
|
118547
|
120040
|
120041
|
120042
|
120043
|
120044
|
120045
|
120046
|
120963
|
120964
|
120965
|
120966
|
120967
|
120968
|
120969
|
120970
|
120979
|
120980
|
120981
|
120982
|
120983
|
120984
|
120985
|
120986
|
120987
|
120988
|
120989
|
120990
|
120991
|
121004
|
121005
|
121006
|
121007
|
121008
|
121009
|
121010
|
121011
|
121012
|
121013
|
121014
|
121015
|
121016
|
121028
|
121757
|
121758
|
121759
|
121760
|
121761
|
121762
|
121763
|
121764
|
121765
|
121766
|
121767
|
121768
|
121769
|
121960
|
121961
|
121962
|
121963
|
121964
|
121965
|
121966
|
121967
|
121968
|
121969
|
121970
|
121971
|
121972
|
122148
|
122149
|
122150
|
122151
|
122152
|
122153
|
122154
|
122155
|
122156
|
122157
|
122158
|
122159
|
122160
|
122161
|
122235
|
122236
|
122237
|
122238
|
122239
|
122240
|
122241
|
122242
|
122243
|
122244
|
122245
|
122246
|
122247
|
122248
|
122249
|
122250
|
122251
|
122252
|
122253
|
122256
|
122257
|
122258
|
122259
|
122260
|
122261
|
122262
|
122263
|
122264
|
122265
|
122266
|
122267
|
122268
|
122269
|
122270
|
122271
|
122272
|
122273
|
122274
|
122553
|
122554
|
122555
|
122556
|
122557
|
122558
|
122559
|
122560
|
122561
|
122562
|
122563
|
122564
|
122565
|
122566
|
122567
|
122568
|
122569
|
122570
|
122571
|
122586
|
122899
|
122900
|
122901
|
122902
|
122903
|
122904
|
122905
|
122906
|
122907
|
122908
|
122909
|
122910
|
122911
|
122912
|
122913
|
122914
|
122915
|
122916
|
122917
|
122918
|
122937
|
123423
|
123424
|
123425
|
123426
|
123427
|
123428
|
123429
|
123430
|
123431
|
123432
|
123433
|
123434
|
123435
|
123436
|
123437
|
123438
|
123439
| 123440 |
123441
|
123442
|
123443