Bugzilla – Attachment 123445 Details for
Bug 28810
Housebound details should be textarea not text inputs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28810: replace housebould detail inputs with textarea
Bug-28810-replace-housebould-detail-inputs-with-te.patch (text/plain), 6.73 KB, created by
Lucas Gass (lukeg)
on 2021-08-03 21:33:49 UTC
(
hide
)
Description:
Bug 28810: replace housebould detail inputs with textarea
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2021-08-03 21:33:49 UTC
Size:
6.73 KB
patch
obsolete
>From 2c971d88e2340f0e013a2deaf9b5827cf41f6fe8 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 3 Aug 2021 21:24:17 +0000 >Subject: [PATCH] Bug 28810: replace housebould detail inputs with textarea > >To test: >1. apply patch >2. enable housebound module >3. go to a patron and look at the housebound tab >4. Edit the detials. >5. The preferred materials, subjects, authors, referral, and note inputs should be replace with much larger textareas. >6. You should now be able to added line breaks, so fill out each of the fields adding some line breaks. I added something like: >Fiction authors: Frank Herbert >Non-fiction authors: Malcolm Gladwell > >7. Save changes >8. Now when you look at the housebound details those line breaks should be preserved and much easier to read. >--- > .../prog/en/modules/members/housebound.tt | 45 +++++++++---------- > 1 file changed, 20 insertions(+), 25 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt >index f494bd8cab..51488f2d59 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt >@@ -151,46 +151,41 @@ > <li> > <label for="fav_itemtypes">Preferred materials:</label> > [% IF ( housebound_profile ) %] >- <input id="fav_itemtypes" type="text" size="50" name="fav_itemtypes" >- value="[% housebound_profile.fav_itemtypes | html %]"> >+ <textarea id="fav_itemtypes" name="fav_itemtypes" cols="110" rows="10">[% housebound_profile.fav_itemtypes | html %]</textarea> > [% ELSE %] >- <input id="fav_itemtypes" type="text" value="" size="50" name="fav_itemtypes"> >+ <textarea id="fav_itemtypes" name="fav_itemtypes" cols="110" rows="10"></textarea> > [% END %] > </li> > <li> > <label for="fav_subjects">Subjects:</label> > [% IF ( housebound_profile ) %] >- <input id="fav_subjects" type="text" size="50" name="fav_subjects" >- value="[% housebound_profile.fav_subjects | html %]"> >+ <textarea id="fav_subjects" name="fav_subjects" cols="110" rows="10">[% housebound_profile.fav_subjects | html %]</textarea> > [% ELSE %] >- <input id="fav_subjects" type="text" value="" size="50" name="fav_subjects"> >+ <textarea id="fav_subjects" name="fav_subjects" cols="110" rows="10"></textarea> > [% END %] > </li> > <li> > <label for="fav_authors">Authors:</label> > [% IF ( housebound_profile ) %] >- <input id="fav_authors" type="text" size="50" name="fav_authors" >- value="[% housebound_profile.fav_authors | html %]"> >+ <textarea id="fav_authors" name="fav_authors" cols="110" rows="10">[% housebound_profile.fav_authors | html %]</textarea> > [% ELSE %] >- <input id="fav_authors" type="text" value="" size="50" name="fav_authors"> >+ <textarea id="fav_authors" name="fav_authors" cols="110" rows="10"></textarea> > [% END %] > </li> > <li> > <label for="referral">Referral:</label> > [% IF ( housebound_profile ) %] >- <input id="referral" type="text" size="50" name="referral" >- value="[% housebound_profile.referral | html %]"> >+ <textarea id="referral" name="referral" cols="110" rows="10">[% housebound_profile.referral | html %]</textarea> > [% ELSE %] >- <input id="referral" type="text" value="" size="50" name="referral"> >+ <textarea id="referral" name="referral" cols="110" rows="10"></textarea> > [% END %] > </li> > <li> > <label for="notes">Notes:</label> > [% IF ( housebound_profile ) %] >- <input id="notes" type="text" size="50" name="notes" >- value="[% housebound_profile.notes | html %]"> >+ <textarea id="notes" name="notes" cols="110" rows="10">[% housebound_profile.notes | html %]</textarea> > [% ELSE %] >- <input id="notes" type="text" value="" size="50" name="notes"> >+ <textarea id="notes" name="notes" cols="110" rows="10"></textarea> > [% END %] > </li> > </ol> >@@ -360,24 +355,24 @@ > [% AuthorisedValues.GetByCode( 'HSBND_FREQ', housebound_profile.frequency, 0 ) || housebound_profile.frequency | html %] > </li> > <li> >- <span class="label">Material:</span> >- [% housebound_profile.fav_itemtypes | html %] >+ <span class="label">Material:</span><br /> >+ [% housebound_profile.fav_itemtypes | html | html_line_break %] > </li> > <li> >- <span class="label">Subjects:</span> >- [% housebound_profile.fav_subjects | html %] >+ <span class="label">Subjects:</span><br /> >+ [% housebound_profile.fav_subjects | html | html_line_break %] > </li> > <li> >- <span class="label">Authors:</span> >- [% housebound_profile.fav_authors | html %] >+ <span class="label">Authors:</span><br /> >+ [% housebound_profile.fav_authors | html | html_line_break %] > </li> > <li> >- <span class="label">Referral:</span> >- [% housebound_profile.referral | html %] >+ <span class="label">Referral:</span><br /> >+ [% housebound_profile.referral | html | html_line_break %] > </li> > <li> >- <span class="label">Notes:</span> >- [% housebound_profile.notes | html %] >+ <span class="label">Notes:</span><br /> >+ [% housebound_profile.notes | html | html_line_break %] > </li> > </ol> > <div class="action"> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28810
:
123445
|
123455
|
124221