Bugzilla – Attachment 123488 Details for
Bug 22690
Merging records with many items too slow (Elasticsearch)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22690: (QA follow-up) Rename 'item_orders' to 'orders'
Bug-22690-QA-follow-up-Rename-itemorders-to-orders.patch (text/plain), 1.65 KB, created by
Martin Renvoize (ashimema)
on 2021-08-05 13:28:53 UTC
(
hide
)
Description:
Bug 22690: (QA follow-up) Rename 'item_orders' to 'orders'
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-08-05 13:28:53 UTC
Size:
1.65 KB
patch
obsolete
>From b658052e79fcf421b9a551b3e5f6d618e51c5241 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 22 Jul 2021 09:56:49 +0100 >Subject: [PATCH] Bug 22690: (QA follow-up) Rename 'item_orders' to 'orders' > >--- > Koha/Item.pm | 8 ++++---- > t/db_dependent/Koha/Item.t | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/Koha/Item.pm b/Koha/Item.pm >index 0b346217e9..c73a298f54 100644 >--- a/Koha/Item.pm >+++ b/Koha/Item.pm >@@ -1172,15 +1172,15 @@ sub itemtype { > return Koha::ItemTypes->find( $self->effective_itemtype ); > } > >-=head3 item_orders >+=head3 orders > >-my $orders = $item->item_orders(); >+ my $orders = $item->orders(); > > Returns a Koha::Acquisition::Orders object > > =cut > >-sub item_orders { >+sub orders { > my ( $self ) = @_; > > my $orders = $self->_result->item_orders; >@@ -1229,7 +1229,7 @@ sub move_to_biblio { > } > > # Acquisition orders >- my $orders = $self->item_orders; >+ my $orders = $self->orders; > if ($orders) { > $orders->update({ biblionumber => $to_biblionumber }, { no_triggers => 1 }); > } >diff --git a/t/db_dependent/Koha/Item.t b/t/db_dependent/Koha/Item.t >index 18dcca46a2..d03a60a30a 100755 >--- a/t/db_dependent/Koha/Item.t >+++ b/t/db_dependent/Koha/Item.t >@@ -856,7 +856,7 @@ subtest 'Tests for relationship between item and item_orders via aqorders_item' > }, > }); > >- my $orders = $item->item_orders; >+ my $orders = $item->orders; > is ($orders->count, 1, 'One order found by item with the relationship'); > is ($orders->next->order_internalnote, $order_note, 'Correct order found by item with the relationship'); > }; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22690
:
90061
|
90115
|
90116
|
92828
|
94505
|
97696
|
98143
|
98210
|
98211
|
99376
|
99379
|
100316
|
104796
|
104797
|
104871
|
105445
|
106144
|
108777
|
109694
|
110991
|
110994
|
111196
|
111207
|
111236
|
111237
|
112100
|
112184
|
112567
|
112569
|
112754
|
113308
|
113309
|
113941
|
113942
|
113967
|
113968
|
118226
|
118227
|
118229
|
118231
|
118391
|
119433
|
119434
|
120820
|
120821
|
120852
|
120853
|
121389
|
121392
|
121474
|
121516
|
121517
|
121518
|
121519
|
121520
|
122846
|
122847
|
122848
|
122849
|
122850
|
122886
|
122887
|
122888
|
122889
|
122890
|
122936
|
122938
|
122939
|
123029
|
123030
|
123031
|
123032
|
123033
|
123034
|
123035
|
123036
|
123037
|
123038
|
123039
|
123040
|
123041
|
123042
|
123044
|
123062
|
123481
|
123482
|
123483
|
123484
|
123485
|
123486
|
123487
| 123488 |
123489
|
123490
|
123491
|
123492
|
123493
|
123494
|
123495
|
123496
|
123497
|
124176
|
124188
|
124257