Bugzilla – Attachment 123559 Details for
Bug 28784
DoS in opac-search.pl causes OOM situation and 100% CPU (doesn't require login!)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28784: (follow-up) Always make three search boxes
Bug-28784-follow-up-Always-make-three-search-boxes.patch (text/plain), 2.15 KB, created by
Marcel de Rooy
on 2021-08-06 08:06:32 UTC
(
hide
)
Description:
Bug 28784: (follow-up) Always make three search boxes
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2021-08-06 08:06:32 UTC
Size:
2.15 KB
patch
obsolete
>From d257dd343be5272805038043b651902f0e7f6f0a Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 3 Aug 2021 12:17:02 +0000 >Subject: [PATCH] Bug 28784: (follow-up) Always make three search boxes >Content-Type: text/plain; charset=utf-8 > >The previous patch removed search_boxes_loop - that's okay, it was always >getting the same three values. > >If we don't do something in the template though, we get no boxes > >Ultimately this should be a include, and not a hardcoded loop, but keeping changes >small for backporting > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >index f5b48f2769..273f19e070 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >@@ -36,11 +36,11 @@ > [% ELSE %] > <div class="advanced-search-terms"> > [% END # /IF ( expanded_options ) %] >- [% FOREACH search_box IN search_boxes_loop %] >+ [% FOREACH search_box IN [ 1, 2, 3] %] > <div class="search-term-row"> > <div class="search-term-input"> > [% IF ( expanded_options ) %] >- [% IF ( search_box.boolean ) %] >+ [% IF ( !loop.first ) %] > <select name="op" class="form-control"> > <option value="and" selected="selected">and</option> > <option value="or">or</option> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28784
:
123407
|
123409
|
123412
|
123413
|
123414
|
123416
|
123467
|
123468
|
123558
| 123559 |
123560
|
123561
|
123866
|
123867