Bugzilla – Attachment 123579 Details for
Bug 28824
Errant variable declaration in C4::Letters
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28824: Unit test
Bug-28824-Unit-test.patch (text/plain), 2.89 KB, created by
Martin Renvoize (ashimema)
on 2021-08-06 14:08:48 UTC
(
hide
)
Description:
Bug 28824: Unit test
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-08-06 14:08:48 UTC
Size:
2.89 KB
patch
obsolete
>From 7264140d64e329b7eaf9e438b3822ce9ac811736 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 6 Aug 2021 14:59:47 +0100 >Subject: [PATCH] Bug 28824: Unit test > >--- > t/db_dependent/Letters.t | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Letters.t b/t/db_dependent/Letters.t >index 7e5273fb02..1c3698f7ef 100755 >--- a/t/db_dependent/Letters.t >+++ b/t/db_dependent/Letters.t >@@ -324,7 +324,7 @@ $prepared_letter = GetPreparedLetter(( > is( $prepared_letter->{content}, q|And also this one:| . output_pref({ dt => $yesterday_night }) . q|.|, 'dateonly test 3' ); > > $dbh->do(q{INSERT INTO letter (module, code, name, title, content) VALUES ('claimacquisition','TESTACQCLAIM','Acquisition Claim','Item Not Received','<<aqbooksellers.name>>|<<aqcontacts.name>>|<order>Ordernumber <<aqorders.ordernumber>> (<<biblio.title>>) (<<aqorders.quantity>> ordered)</order>');}); >-$dbh->do(q{INSERT INTO letter (module, code, name, title, content) VALUES ('orderacquisition','TESTACQORDER','Acquisition Order','Order','<<aqbooksellers.name>>|<<aqcontacts.name>>|<order>Ordernumber <<aqorders.ordernumber>> (<<biblio.title>>) (<<aqorders.quantity>> ordered)</order>');}); >+$dbh->do(q{INSERT INTO letter (module, code, name, title, content) VALUES ('orderacquisition','TESTACQORDER','Acquisition Order','Order','<<aqbooksellers.name>>|<<aqcontacts.name>>|<<aqbasket.basketname>>|<order>Ordernumber <<aqorders.ordernumber>> (<<biblio.title>>) (<<aqorders.quantity>> ordered)</order>');}); > > # Test that _parseletter doesn't modify its parameters bug 15429 > { >@@ -361,7 +361,7 @@ my $booksellerid = $bookseller->id; > > Koha::Acquisition::Bookseller::Contact->new( { name => 'John Smith', phone => '0123456x1', claimacquisition => 1, orderacquisition => 1, booksellerid => $booksellerid } )->store; > Koha::Acquisition::Bookseller::Contact->new( { name => 'Leo Tolstoy', phone => '0123456x2', claimissues => 1, booksellerid => $booksellerid } )->store; >-my $basketno = NewBasket($booksellerid, 1); >+my $basketno = NewBasket($booksellerid, 1, 'Named basket'); > > my $budgetid = C4::Budgets::AddBudget({ > budget_code => "budget_code_test_letters", >@@ -426,7 +426,7 @@ warning_like { > "SendAlerts is using the mocked send_or_die routine (orderacquisition)"; > is($err, 1, "Successfully sent order."); > is($email_object->email->header('To'), 'testemail@mydomain.com', "mailto correct in sent order"); >-is($email_object->email->body, 'my vendor|John Smith|Ordernumber ' . $ordernumber . ' (Silence in the library) (1 ordered)', 'Order notice text constructed successfully'); >+is($email_object->email->body, 'my vendor|John Smith|Named basket|Ordernumber ' . $ordernumber . ' (Silence in the library) (1 ordered)', 'Order notice text constructed successfully'); > > my $mocked_koha_email = Test::MockModule->new('Koha::Email'); > $mocked_koha_email->mock( 'send_or_die', sub { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28824
: 123579 |
123580