Bugzilla – Attachment 123594 Details for
Bug 28828
Bug 22399 breaks unimarc_field_4XX.tt and marc21_linking_section.tt value builders
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28828: Bug 22399 impact on value_builder/unimarc_field_4XX.tt
Bug-28828-Bug-22399-impact-on-valuebuilderunimarcf.patch (text/plain), 1.82 KB, created by
David Nind
on 2021-08-07 11:47:51 UTC
(
hide
)
Description:
Bug 28828: Bug 22399 impact on value_builder/unimarc_field_4XX.tt
Filename:
MIME Type:
Creator:
David Nind
Created:
2021-08-07 11:47:51 UTC
Size:
1.82 KB
patch
obsolete
>From 6138dd9160c255bd004f53f2f5b21fd5eeda2215 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Fri, 6 Aug 2021 15:38:35 -1000 >Subject: [PATCH] Bug 28828: Bug 22399 impact on > value_builder/unimarc_field_4XX.tt > >Since Bug 22399 changes in biblio editor, value builder unimarc_field_4XX.tt JavaScript code does not do its job anymore. >This is because a div is added and this call is now wrong : > var subfields = whichfield.parentNode.parentNode.getElementsByTagName('input'); >It needs one more parent. > >Test plan : >1) Use a UNIMARC DB >2) Define value builder unimarc_field_4XX on 463$t >3) Create a record B1 with 200$a, 200$f >4) Create a new record B2 >5) Click on value builder in 463$t >6) Search for record B1 >7) Click on "Choose" >=> Without patch only 463$t is filled with a value >=> With patch 463 $t, $a, $0 and $9 are filled with a value > >Signed-off-by: David Nind <david@davidnind.com> >--- > .../en/modules/cataloguing/value_builder/unimarc_field_4XX.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt >index 8f37e9143b..330214b65d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt >@@ -159,7 +159,7 @@ > > // browse all its subfields > >- var subfields = whichfield.parentNode.parentNode.getElementsByTagName('input'); >+ var subfields = whichfield.parentNode.parentNode.parentNode.getElementsByTagName('input'); > > var re = /^tag_\d*_code_/; > for(var i=0, len = subfields.length ; i< len ; i++) { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28828
:
123591
|
123592
|
123594
|
123642
|
123666
|
123687