Attachment 123598 Details for Bug 28829 – Bug 28829: Remove single quote escaping in value_builder/unimarc_field_4XX.pl

[patch] Bug 28829: Remove single quote escaping in value_builder/unimarc_field_4XX.pl

Bug-28829-Remove-single-quote-escaping-in-valuebui.patch (text/plain), 2.07 KB, created by David Nind on 2021-08-08 11:26:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2021-08-08 11:26:39 UTC

Size: 2.07 KB

patch

obsolete

>From 41ed6d4553251cf1036dc81232e79b13f767a7b1 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Fri, 6 Aug 2021 16:02:09 -1000
>Subject: [PATCH] Bug 28829: Remove single quote escaping in
> value_builder/unimarc_field_4XX.pl
>
>Since Bug 23777 added To.json, single quote escaping in value_builder/unimarc_field_4XX.pl is useless.
>
>Test plan:
>1) Use UNIMARC database
>2) Define value builder unimarc_field_4XX on 463$t
>3) Create a record B1 with 200$a : L'avion
>4) Create a record B2
>5) Click on value builder in 463$t
>6) Search for record B1
>7) Click on "Choose"
>=> Without patch 463$t contains : L\'avion
>=> With patch 463$t contains : L'avion
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> cataloguing/value_builder/unimarc_field_4XX.pl | 18 ------------------
> 1 file changed, 18 deletions(-)
>
>diff --git a/cataloguing/value_builder/unimarc_field_4XX.pl b/cataloguing/value_builder/unimarc_field_4XX.pl
>index 832305929a..db0bbd26ed 100755
>--- a/cataloguing/value_builder/unimarc_field_4XX.pl
>+++ b/cataloguing/value_builder/unimarc_field_4XX.pl
>@@ -307,24 +307,6 @@ sub plugin {
>         if   ( $marcrecord->field('010') ) {
>             $subfield_value_y = $marcrecord->field('010')->subfield("a");
>         }
>-        # escape the 's
>-        $subfield_value_9 =~ s/'/\\'/g;
>-        $subfield_value_0 =~ s/'/\\'/g;
>-        $subfield_value_a =~ s/'/\\'/g;
>-        $subfield_value_c =~ s/'/\\'/g;
>-        $subfield_value_d =~ s/'/\\'/g;
>-        $subfield_value_e =~ s/'/\\'/g;
>-        $subfield_value_h =~ s/'/\\'/g;
>-        $subfield_value_i =~ s/'/\\'/g;
>-        $subfield_value_l =~ s/'/\\'/g;
>-        $subfield_value_n =~ s/'/\\'/g;
>-        $subfield_value_o =~ s/'/\\'/g;
>-        $subfield_value_p =~ s/'/\\'/g;
>-        $subfield_value_t =~ s/'/\\'/g;
>-        $subfield_value_u =~ s/'/\\'/g;
>-        $subfield_value_v =~ s/'/\\'/g;
>-        $subfield_value_x =~ s/'/\\'/g;
>-        $subfield_value_y =~ s/'/\\'/g;
>         $template->param(
>             fillinput        => 1,
>             index            => scalar $query->param('index') . "",
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28829: 123593 | 123598 | 124783