Attachment 123607 Details for Bug 28484 – Bug 28484: ES clean title in biblio detail

[patch] Bug 28484: ES clean title in biblio detail

Bug-28484-ES-clean-title-in-biblio-detail.patch (text/plain), 2.02 KB, created by Alex Buckley on 2021-08-08 23:36:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Buckley

Created: 2021-08-08 23:36:24 UTC

Size: 2.02 KB

patch

obsolete

>From 571eb44e00fdb51316dbde95705d81be6108ec40 Mon Sep 17 00:00:00 2001
>From: Alex Arnaud <alex.arnaud@biblibre.com>
>Date: Thu, 22 Jul 2021 11:45:15 +0000
>Subject: [PATCH] Bug 28484: ES clean title in biblio detail
>
>Test plan:
> - Create a biblio with title like "osteuropa:" or "osteuropa!"
> - Go the this biblio detail pages (cgi-bin/koha/catalogue/detail.pl)
>   => Error
> - Apply bug 28316 and this one
> - test again
>
>Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
>---
> Koha/SearchEngine/Zebra/QueryBuilder.pm | 13 +++++++++++++
> catalogue/detail.pl                     |  6 ++++++
> 2 files changed, 19 insertions(+)
>
>diff --git a/Koha/SearchEngine/Zebra/QueryBuilder.pm b/Koha/SearchEngine/Zebra/QueryBuilder.pm
>index 2fc1e1ae8e..7094ae6cee 100644
>--- a/Koha/SearchEngine/Zebra/QueryBuilder.pm
>+++ b/Koha/SearchEngine/Zebra/QueryBuilder.pm
>@@ -73,4 +73,17 @@ sub build_authorities_query_compat {
>     build_authorities_query(@_);
> }
> 
>+
>+=head2 _clean_search_term
>+
>+    my $term = $self->_clean_search_term($term);
>+
>+=cut
>+
>+sub _clean_search_term {
>+    my ( $self, $term ) = @_;
>+
>+    return $term;
>+}
>+
> 1;
>diff --git a/catalogue/detail.pl b/catalogue/detail.pl
>index b06c90a866..9e2318c371 100755
>--- a/catalogue/detail.pl
>+++ b/catalogue/detail.pl
>@@ -55,6 +55,7 @@ use Koha::Patrons;
> use Koha::Virtualshelves;
> use Koha::Plugins;
> use Koha::SearchEngine::Search;
>+use Koha::SearchEngine::QueryBuilder;
> 
> my $query = CGI->new();
> 
>@@ -132,8 +133,13 @@ if ( $xslfile ) {
>     my $searcher = Koha::SearchEngine::Search->new(
>         { index => $Koha::SearchEngine::BIBLIOS_INDEX }
>     );
>+    my $builder = Koha::SearchEngine::QueryBuilder->new(
>+        { index => $Koha::SearchEngine::BIBLIOS_INDEX } );
>+
>     my $cleaned_title = $biblio->title;
>     $cleaned_title =~ tr|/||;
>+    $cleaned_title = $builder->_clean_search_term($cleaned_title);
>+
>     my $query =
>       ( C4::Context->preference('UseControlNumber') and $record->field('001') )
>       ? 'rcn:'. $record->field('001')->data . ' AND (bib-level:a OR bib-level:b)'
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 28484: 123045 | 123607 | 124379 | 125433 | 125434 | 125435