Bugzilla – Attachment 123651 Details for
Bug 28764
Sorting not correct in pagination on OPAC lists
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28764: Alter sort dropdown to use direction parameter
Bug-28764-Alter-sort-dropdown-to-use-direction-par.patch (text/plain), 9.70 KB, created by
Marcel de Rooy
on 2021-08-09 13:54:12 UTC
(
hide
)
Description:
Bug 28764: Alter sort dropdown to use direction parameter
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2021-08-09 13:54:12 UTC
Size:
9.70 KB
patch
obsolete
>From 9a3c97253c17cd0f4c605ed8428e55eba704e27b Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 30 Jul 2021 10:54:47 +0000 >Subject: [PATCH] Bug 28764: Alter sort dropdown to use direction parameter >Content-Type: text/plain; charset=utf-8 > >This code is odd -we build a select in the template, then turn it into a list of links using javascript >This patch adds a direction data element and uses it while building the links > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > .../bootstrap/en/modules/opac-shelves.tt | 42 +++++++++---------- > 1 file changed, 21 insertions(+), 21 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >index b9d3c0858d..08b7f668a6 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >@@ -265,62 +265,62 @@ > <option value="">Default sorting</option> > <optgroup label="Author"> > [% IF sortfield == 'author' && direction == 'asc' %] >- <option value="author:asc" selected="selected">Author (A-Z)</option> >+ <option value="author" data-direction="asc" selected="selected">Author (A-Z)</option> > [% ELSE %] >- <option value="author:asc">Author (A-Z)</option> >+ <option value="author" data-direction="asc">Author (A-Z)</option> > [% END %] > [% IF sortfield == 'author' && direction == 'desc' %] >- <option value="author:desc" selected="selected">Author (Z-A)</option> >+ <option value="author" data-direction="desc" selected="selected">Author (Z-A)</option> > [% ELSE %] >- <option value="author:desc">Author (Z-A)</option> >+ <option value="author" data-direction="desc">Author (Z-A)</option> > [% END %] > </optgroup> > <optgroup label="Title"> > [% IF sortfield == 'title' && direction == 'asc' %] >- <option value="title:asc" selected="selected">Title (A-Z)</option> >+ <option value="title" data-direction="asc" selected="selected">Title (A-Z)</option> > [% ELSE %] >- <option value="title:asc">Title (A-Z)</option> >+ <option value="title" data-direction="asc">Title (A-Z)</option> > [% END %] > [% IF sortfield == 'title' && direction == 'desc' %] >- <option value="title:desc" selected="selected">Title (Z-A)</option> >+ <option value="title" data-direction="desc" selected="selected">Title (Z-A)</option> > [% ELSE %] >- <option value="title:desc">Title (Z-A)</option> >+ <option value="title" data-direction="desc">Title (Z-A)</option> > [% END %] > </optgroup> > <optgroup label="Call number"> > [% IF sortfield == 'itemcallnumber' && direction == 'asc' %] >- <option value="itemcallnumber:asc" selected="selected">Call number (A-Z)</option> >+ <option value="itemcallnumber" data-direction="asc" selected="selected">Call number (A-Z)</option> > [% ELSE %] >- <option value="itemcallnumber:asc">Call number (A-Z)</option> >+ <option value="itemcallnumber" data-direction="asc">Call number (A-Z)</option> > [% END %] > [% IF sortfield == 'itemcallnumber' && direction == 'desc' %] >- <option value="itemcallnumber:desc" selected="selected">Call number (Z-A)</option> >+ <option value="itemcallnumber" data-direction="desc" selected="selected">Call number (Z-A)</option> > [% ELSE %] >- <option value="itemcallnumber:desc">Call number (Z-A)</option> >+ <option value="itemcallnumber" data-direction="desc">Call number (Z-A)</option> > [% END %] > </optgroup> > <optgroup label="Copyright date"> > [% IF sortfield == 'copyrightdate' && direction == 'asc' %] >- <option value="copyrightdate:desc" selected="selected">Copyright date (newest to oldest)</option> >+ <option value="copyrightdate" data-direction="desc" selected="selected">Copyright date (newest to oldest)</option> > [% ELSE %] >- <option value="copyrightdate:desc">Copyright date (newest to oldest)</option> >+ <option value="copyrightdate" data-direction="desc">Copyright date (newest to oldest)</option> > [% END %] > [% IF sortfield == 'copyrightdate' && direction == 'desc' %] >- <option value="copyrightdate:asc" selected="selected">Copyright date (oldest to newest)</option> >+ <option value="copyrightdate" data-direction="asc" selected="selected">Copyright date (oldest to newest)</option> > [% ELSE %] >- <option value="copyrightdate:asc">Copyright date (oldest to newest)</option> >+ <option value="copyrightdate" data-direction="asc">Copyright date (oldest to newest)</option> > [% END %] > </optgroup> > <optgroup label="Date added"> > [% IF sortfield == "dateadded" && direction == 'asc' %] >- <option value="dateadded:desc" selected="selected">Date added (newest to oldest)</option> >+ <option value="dateadded" data-direction="desc" selected="selected">Date added (newest to oldest)</option> > [% ELSE %] >- <option value="dateadded:desc">Date added (newest to oldest)</option> >+ <option value="dateadded" data-direction="desc">Date added (newest to oldest)</option> > [% END %] > [% IF sortfield == "dateadded" && direction == 'desc' %] >- <option value="dateadded:asc" selected="selected">Date added (oldest to newest)</option> >+ <option value="dateadded" data-direction="asc" selected="selected">Date added (oldest to newest)</option> > [% ELSE %] >- <option value="dateadded:asc">Date added (oldest to newest)</option> >+ <option value="dateadded" data-direction="asc">Date added (oldest to newest)</option> > [% END %] > </optgroup> > </select> >@@ -1083,7 +1083,7 @@ function sortMenu( sorting_form ){ > menu += "<span class=\"dropdown-header\">" + $(this).attr("label") + "</span>"; > $(this).children().each(function(){ > if( $(this)[0].tagName.toUpperCase() == "OPTION" ){ >- menu += "<a class=\"dropdown-item\" href=\"" + sort_link + $(this).val() + "\">" + $(this).text() + "</a>"; >+ menu += "<a class=\"dropdown-item\" href=\"" + sort_link + $(this).val() + "&direction=" + $(this).data('direction') + "\">" + $(this).text() + "</a>"; > } > }); > } >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28764
:
123205
|
123207
|
123297
|
123650
| 123651 |
123652