Attachment 123664 Details for Bug 28825 – Bug 28825: Can't edit local cover image for item from details page

[patch] Bug 28825: Can't edit local cover image for item from details page

Bug-28825-Cant-edit-local-cover-image-for-item-fro.patch (text/plain), 2.64 KB, created by Katrin Fischer on 2021-08-10 09:48:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2021-08-10 09:48:36 UTC

Size: 2.64 KB

patch

obsolete

>From d575dfa960c18b1f32a290e552d4da41317aeca8 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 6 Aug 2021 16:49:50 +0000
>Subject: [PATCH] Bug 28825: Can't edit local cover image for item from details
> page
>
>This patch corrects the markup for local cover images attached to items.
>The correction allows correct display of an "edit" link when the user
>clicks an item's cover image and views it in the lightbox-style modal.
>
>To test, apply the patch and make sure the "LocalCoverImages" system
>preference is enabled.
>
>- View the details of a bibliographic record in the catalog which has
>  items attached..
>- In the table of holdings, click Edit -> Upload image.
>- Upload an image for the item and return to the bibliographic detail
>  page.
>- Your image should now be displayed in the holdings table.
>- Click the image to view it.
>- In the footer of the modal there is an edit link: "Local cover image
>  (edit). Before this patch the edit link would lead to a missing page.
>  After applying the patch the link should take you to the "Image view"
>  where you have the option of deleting the image or uploading another
>  one.
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index 494e836e26..4f7589697a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -364,7 +364,7 @@
>                                     [% FOREACH image IN item.cover_images %]
>                                         <div class="cover-image local-coverimg">
>                                             <a href="/cgi-bin/koha/catalogue/image.pl?itemnumber=[% image.itemnumber | uri %]&amp;imagenumber=[% image.imagenumber | uri %]" title="Local cover image">
>-                                                <img src="/cgi-bin/koha/catalogue/image.pl?thumbnail=1&amp;imagenumber=[% image.imagenumber | uri %]" alt="Local cover image" />
>+                                                <img src="/cgi-bin/koha/catalogue/image.pl?thumbnail=1&amp;imagenumber=[% image.imagenumber | uri %]" alt="Local cover image" data-link="/cgi-bin/koha/catalogue/imageviewer.pl?itemnumber=[% item.itemnumber | uri %]&amp;imagenumber=[% image.imagenumber | uri %]" />
>                                             </a>
>                                         </div>
>                                     [% END %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 28825: 123584 | 123600 | 123663 | 123664