Attachment 123735 Details for Bug 28765 – Bug 28765: Remove sub find_value from batchMod.pl

[patch] Bug 28765: Remove sub find_value from batchMod.pl

Bug-28765-Remove-sub-findvalue-from-batchModpl.patch (text/plain), 1.24 KB, created by Martin Renvoize (ashimema) on 2021-08-11 06:53:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-08-11 06:53:48 UTC

Size: 1.24 KB

patch

obsolete

>From 70dacf2be9a697523b40e1b58482c9d69941d57f Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 26 Jul 2021 18:31:43 +0200
>Subject: [PATCH] Bug 28765: Remove sub find_value from batchMod.pl
>
>It has never been used and should be removed
>
>Test plan:
>Search for "find_value" in the file and confirm that there is no more
>occurrence
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> tools/batchMod.pl | 16 ----------------
> 1 file changed, 16 deletions(-)
>
>diff --git a/tools/batchMod.pl b/tools/batchMod.pl
>index 4f0efe833e..0f57a2debd 100755
>--- a/tools/batchMod.pl
>+++ b/tools/batchMod.pl
>@@ -757,19 +757,3 @@ sub UpdateMarcWith {
>     }
>     return $modified;
> }
>-
>-sub find_value {
>-    my ($tagfield,$insubfield,$record) = @_;
>-    my $result;
>-    my $indicator;
>-    foreach my $field ($record->field($tagfield)) {
>-        my @subfields = $field->subfields();
>-        foreach my $subfield (@subfields) {
>-            if (@$subfield[0] eq $insubfield) {
>-                $result .= @$subfield[1];
>-                $indicator = $field->indicator(1).$field->indicator(2);
>-            }
>-        }
>-    }
>-    return($indicator,$result);
>-}
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28765: 123211 | 123353 | 123735