Bugzilla – Attachment 123785 Details for
Bug 28833
Speed up holds queue builder via parallel processing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28833: (follow-up) Move loops count control to koha conf
Bug-28833-follow-up-Move-loops-count-control-to-ko.patch (text/plain), 4.90 KB, created by
Kyle M Hall (khall)
on 2021-08-11 11:50:31 UTC
(
hide
)
Description:
Bug 28833: (follow-up) Move loops count control to koha conf
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2021-08-11 11:50:31 UTC
Size:
4.90 KB
patch
obsolete
>From d007ef0504a2cd9bbe21f048c390cab2e9c1c9fe Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 11 Aug 2021 07:45:31 -0400 >Subject: [PATCH] Bug 28833: (follow-up) Move loops count control to koha conf > >--- > debian/templates/koha-conf-site.xml.in | 4 ++++ > etc/koha-conf.xml | 4 ++++ > installer/data/mysql/atomicupdate/bug_28833.perl | 9 --------- > installer/data/mysql/mandatory/sysprefs.sql | 1 - > .../prog/en/modules/admin/preferences/circulation.pref | 5 ----- > misc/cronjobs/holds/build_holds_queue.pl | 2 +- > 6 files changed, 9 insertions(+), 16 deletions(-) > delete mode 100644 installer/data/mysql/atomicupdate/bug_28833.perl > >diff --git a/debian/templates/koha-conf-site.xml.in b/debian/templates/koha-conf-site.xml.in >index 6525e4ce97..e27a9806dd 100644 >--- a/debian/templates/koha-conf-site.xml.in >+++ b/debian/templates/koha-conf-site.xml.in >@@ -449,5 +449,9 @@ __END_SRU_PUBLICSERVER__ > <vhost>__MESSAGE_BROKER_VHOST__</vhost> > </message_broker> > >+ <holds_queue_builder> >+ <parallel_loops_count>1</parallel_loops_count> >+ </holds_queue_builder> >+ > </config> > </yazgfs> >diff --git a/etc/koha-conf.xml b/etc/koha-conf.xml >index 118b6b8207..5e00ea6475 100644 >--- a/etc/koha-conf.xml >+++ b/etc/koha-conf.xml >@@ -266,5 +266,9 @@ > <vhost></vhost> > </message_broker> > >+ <holds_queue_builder> >+ <parallel_loops_count>1</parallel_loops_count> >+ </holds_queue_builder> >+ > </config> > </yazgfs> >diff --git a/installer/data/mysql/atomicupdate/bug_28833.perl b/installer/data/mysql/atomicupdate/bug_28833.perl >deleted file mode 100644 >index 1d0c1adcca..0000000000 >--- a/installer/data/mysql/atomicupdate/bug_28833.perl >+++ /dev/null >@@ -1,9 +0,0 @@ >-$DBversion = 'XXX'; # will be replaced by the RM >-if( CheckVersion( $DBversion ) ) { >- $dbh->do(q{ >- INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES >- ('HoldsQueueParallelLoopsCount', '1', NULL, 'Number of parallel loops to use when running the holds queue builder', 'Integer'); >- }); >- >- NewVersion( $DBversion, 28833, "Speed up holds queue builder via parallel processing"); >-} >diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql >index 0ad4dcb8cc..6b66e42c14 100644 >--- a/installer/data/mysql/mandatory/sysprefs.sql >+++ b/installer/data/mysql/mandatory/sysprefs.sql >@@ -241,7 +241,6 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('HoldsAutoFillPrintSlip','0',NULL,'If on, hold slip print dialog will be displayed automatically','YesNo'), > ('HoldsLog','0',NULL,'If ON, log create/cancel/suspend/resume actions on holds.','YesNo'), > ('HoldsNeedProcessingSIP', '0', NULL, 'Require staff to check-in before hold is set to waiting state', 'YesNo' ), >-('HoldsQueueParallelLoopsCount', '1', NULL, 'Number of parallel loops to use when running the holds queue builder', 'Integer'), > ('HoldsQueueSkipClosed', '0', NULL, 'If enabled, any libraries that are closed when the holds queue is built will be ignored for the purpose of filling holds.', 'YesNo'), > ('HoldsSplitQueue','nothing','nothing|branch|itemtype|branch_itemtype','In the staff interface, split the holds view by the given criteria','Choice'), > ('HoldsToPullStartDate','2',NULL,'Set the default start date for the Holds to pull list to this many days ago','Integer'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >index d3f26f09ac..3c10f1a69f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >@@ -74,11 +74,6 @@ Circulation: > - pref: HoldsToPullStartDate > class: integer > - day(s) ago. Note that the default end date is controlled by the system preference <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ConfirmFutureHolds">ConfirmFutureHolds</a>. >- - >- - When building the holds queue, calculate hold matches using >- - pref: HoldsQueueParallelLoopsCount >- class: integer >- - parallel loop(s). The more loops used, the faster it will calculate and the more computing resources it will use. > - > - pref: AllowAllMessageDeletion > choices: >diff --git a/misc/cronjobs/holds/build_holds_queue.pl b/misc/cronjobs/holds/build_holds_queue.pl >index a3815511a3..2b9fff4965 100755 >--- a/misc/cronjobs/holds/build_holds_queue.pl >+++ b/misc/cronjobs/holds/build_holds_queue.pl >@@ -22,6 +22,6 @@ use C4::Context; > > cronlogaction(); > >-my $loops = C4::Context->preference('HoldsQueueParallelLoopsCount'); >+my $loops = C4::Context->config('holds_queue_builder')->{parallel_loops_count}; > CreateQueue($loops); > >-- >2.30.1 (Apple Git-130)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28833
:
123656
|
123657
|
123659
|
123671
|
123679
|
123688
|
123689
|
123783
|
123784
|
123785
|
123786
|
123996
|
126200
|
126202
|
126216
|
167349
|
173045
|
173046
|
173262