Bugzilla – Attachment 123812 Details for
Bug 7703
Don't block bulk hold action on search results if some items can't be placed on hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7703: Don't block bulk hold action on search results if some items can't be placed on hold
Bug-7703-Dont-block-bulk-hold-action-on-search-res.patch (text/plain), 4.85 KB, created by
Kyle M Hall (khall)
on 2021-08-12 14:06:02 UTC
(
hide
)
Description:
Bug 7703: Don't block bulk hold action on search results if some items can't be placed on hold
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2021-08-12 14:06:02 UTC
Size:
4.85 KB
patch
obsolete
>From e68e505695976198750eb2a5131660a051601283 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 6 Aug 2021 11:19:12 +0000 >Subject: [PATCH] Bug 7703: Don't block bulk hold action on search results if > some items can't be placed on hold > >If you select multiple titles on the search results page in order to >place a bulk hold and some of those titles have no items you get a >JavaScript alert warning you can some cannot be placed on hold. You are >blocked from completing the action until you deselect the invalid hold. > >This is unnecessary because the bulk hold process will safely refuse to >place a hold on these titles later in the process. > >This patch removes the check that prevents submitting a multi-hold if >one or more records in the multi-hold have no items. > >Test plan: >1) Apply patch >2) On the staff interface, do a search >3) On the search results, select at least one record with items and one > record with no items. >4) Click the 'Place hold' button. >5) You should be redirected to reserve/request.pl with the message > "Cannot place hold: this record has no items attached." > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> >--- > .../prog/en/modules/reserve/request.tt | 20 ++++++++++--------- > .../intranet-tmpl/prog/js/pages/results.js | 9 --------- > 2 files changed, 11 insertions(+), 18 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 8d5839ed0a..4d8266483d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -842,16 +842,18 @@ > [% END %] > </td> > <td> >- <select name="pickup_[% biblioloo.biblionumber | html %]" >- class="multi_pickup_select" >- data-biblio-id="[% biblioloo.biblionumber | html %]" >- data-patron-id="[% patron.borrowernumber | html %]" >- data-pickup-locations='[% biblioloo.pickup_locations_codes.json | $raw %]'> >- <option value=""></option> >- [% FOREACH pickup_location IN biblioloo.pickup_locations %] >- <option value="[% pickup_location.branchcode | html %]">[% pickup_location.branchname | html %]</option> >+ [% UNLESS ( biblioloo.none_avail ) %] >+ <select name="pickup_[% biblioloo.biblionumber | html %]" >+ class="multi_pickup_select" >+ data-biblio-id="[% biblioloo.biblionumber | html %]" >+ data-patron-id="[% patron.borrowernumber | html %]" >+ data-pickup-locations='[% biblioloo.pickup_locations_codes.json | $raw %]'> >+ <option value=""></option> >+ [% FOREACH pickup_location IN biblioloo.pickup_locations %] >+ <option value="[% pickup_location.branchcode | html %]">[% pickup_location.branchname | html %]</option> >+ [% END %] >+ </select> > [% END %] >- </select> > </td> > </tr> > [% END # /FOREACH biblioloo %] >diff --git a/koha-tmpl/intranet-tmpl/prog/js/pages/results.js b/koha-tmpl/intranet-tmpl/prog/js/pages/results.js >index 785817c097..c1bd815cea 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/pages/results.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/pages/results.js >@@ -338,19 +338,10 @@ function placeHold () { > return false; > } > var bibs = ""; >- var badBibs = false; > $(checkedItems).each(function() { > var bib = $(this).val(); >- if ($("#reserve_" + bib).size() == 0) { >- alert( __("One or more selected items cannot be placed on hold.") ); >- badBibs = true; >- return false; >- } > bibs += bib + "/"; > }); >- if (badBibs) { >- return false; >- } > $("#hold_form_biblios").val(bibs); > $("#hold_form").submit(); > return false; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7703
:
9613
|
14360
|
14435
|
15290
|
19114
|
19115
|
28144
|
52166
|
52167
|
52168
|
52295
|
52296
|
123575
|
123576
|
123577
|
123812
|
123813
|
123814
|
124233
|
124234
|
124235