Bugzilla – Attachment 123813 Details for
Bug 7703
Don't block bulk hold action on search results if some items can't be placed on hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7703: (QA follow-up)
Bug-7703-QA-follow-up.patch (text/plain), 3.20 KB, created by
Kyle M Hall (khall)
on 2021-08-12 14:06:06 UTC
(
hide
)
Description:
Bug 7703: (QA follow-up)
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2021-08-12 14:06:06 UTC
Size:
3.20 KB
patch
obsolete
>From 94be095121a0430e7ed1feb764026b3fc66d6a75 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 6 Aug 2021 11:46:12 +0000 >Subject: [PATCH] Bug 7703: (QA follow-up) > >Revised test plan from Owen: > >This patch modifies the hold process so that if one of the titles in a >multi-hold process has no items the process doesn't abort completely. > >To test, apply the patch and perform a search in the catalog which will >return one or more records with no items attached. > > - Check checkboxes for multiple results, some of which have items and > at least one of which has no items. > - Click "Place hold." > - You should be taken to the page for placing multiple holds, with a > heading, "Cannot place hold on some items." > - Note: You will not be able to complete the holds process without the > next patch. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 6 +++--- > reserve/request.pl | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 4d8266483d..2e5fbeaf1c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -864,12 +864,12 @@ > <fieldset class="action"> > [% IF ( patron AND patron.borrowernumber ) %] > [% IF ( override_required ) %] >- <button type="submit" class="btn btn-default warning"><i class="fa fa-exclamation-triangle "></i> Place hold</button> >+ <button type="submit" class="btn btn-default warning"><i class="fa fa-exclamation-triangle "></i> Place holds</button> > [% ELSIF ( none_available ) %] >- <button type="submit" disabled="disabled" class="btn btn-default btn-disabled">Place hold</button> >+ <button class="btn btn-default" type="submit">Place holds</button> > [% ELSE %] > [% IF ( multi_hold ) %] >- <button type="submit" class="btn btn-default" id="multi_hold_submit">Place hold</button> >+ <button type="submit" class="btn btn-default" id="multi_hold_submit">Place holds</button> > [% ELSE %] > <button type="submit" class="btn btn-default">Place hold</button> > [% END %] >diff --git a/reserve/request.pl b/reserve/request.pl >index 2dab6e37d0..6ab8ba7ac5 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -403,7 +403,7 @@ foreach my $biblionumber (@biblionumbers) { > > unless ( $items->count ) { > # FIXME Then why do we continue? >- $template->param('noitems' => 1); >+ $template->param('noitems' => 1) unless ( $multi_hold ); > $biblioloopiter{noitems} = 1; > } > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7703
:
9613
|
14360
|
14435
|
15290
|
19114
|
19115
|
28144
|
52166
|
52167
|
52168
|
52295
|
52296
|
123575
|
123576
|
123577
|
123812
|
123813
|
123814
|
124233
|
124234
|
124235