Attachment 123862 Details for Bug 28861 – Bug 28861: Item type column always hidden in OPAC holds history

[patch] Bug 28861: Item type column always hidden in OPAC holds history

Bug-28861-Item-type-column-always-hidden-in-OPAC-h.patch (text/plain), 2.06 KB, created by David Nind on 2021-08-16 21:06:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2021-08-16 21:06:21 UTC

Size: 2.06 KB

patch

obsolete

>From bc215773e119dc8267167039e71e7162bffc2cd1 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 13 Aug 2021 17:00:38 -0300
>Subject: [PATCH] Bug 28861: Item type column always hidden in OPAC holds
> history
>
>This patch fixes the 'Requested item  type' column not showing for holds
>history in OPAC.
>
>It was due to a template variable not being set. When solved, it become
>clear that an import was missing for a template plugin.
>
>To test:
>1. Enable AllowHoldItemTypeSelection
>2. Add a couple item-type constrained holds
>3. See them in the holds history page
>=> SUCCESS: Item type column shows
>4. Enable OPACHoldsHistory
>5. Look for them in the OPAC
>=> FAIL: The item type column doesn't show
>6. Apply this patch
>7. Repeat 5
>=> SUCCESS: The column shows! The item type is described!
>8. Sign off :-D
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt
>index caa13006ac..bfcd0e073d 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt
>@@ -3,6 +3,7 @@
> [% USE Branches %]
> [% USE KohaDates %]
> [% USE TablesSettings %]
>+[% USE ItemTypes %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Your holds history &rsaquo; [% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Koha online[% END %] catalog</title>
> [% INCLUDE 'doc-head-close.inc' %]
>@@ -66,6 +67,7 @@
>                     [% IF !holds %]
>                         You have never placed a hold from this library.
>                     [% ELSE %]
>+                        [% SET show_itemtype_column = Koha.Preference('AllowHoldItemTypeSelection') %]
>                         <div id="opac-user-holdsrec">
>                             <div id="tabs-container">
>                                 <div class="controls">
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28861: 123842 | 123862 | 123869