Bugzilla – Attachment 123867 Details for
Bug 28784
DoS in opac-search.pl causes OOM situation and 100% CPU (doesn't require login!)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28784: [20.05.x] (follow-up) Always make three search boxes
Bug-28784-2005x-follow-up-Always-make-three-search.patch (text/plain), 1.94 KB, created by
Jonathan Druart
on 2021-08-17 07:59:50 UTC
(
hide
)
Description:
Bug 28784: [20.05.x] (follow-up) Always make three search boxes
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-08-17 07:59:50 UTC
Size:
1.94 KB
patch
obsolete
>From 34edfb23ef77b917f03adad48a18b658cf845533 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 3 Aug 2021 12:17:02 +0000 >Subject: [PATCH] Bug 28784: [20.05.x] (follow-up) Always make three search > boxes > >The previous patch removed search_boxes_loop - that's okay, it was always >getting the same three values. > >If we don't do something in the template though, we get no boxes > >Ultimately this should be a include, and not a hardcoded loop, but keeping changes >small for backporting > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >index a57f731dfcf..9eacf6deef8 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >@@ -24,10 +24,10 @@ > <div id="booleansearch" class="maincontent"> > <fieldset> > <legend>Search for:</legend> >- [% FOREACH search_box IN search_boxes_loop %] >+ [% FOREACH search_box IN [ 1, 2, 3] %] > <p> > [% IF ( expanded_options ) %] >- [% IF ( search_box.boolean ) %] >+ [% IF ( !loop.first ) %] > <select name="op"> > <option value="and" selected="selected">and</option> > <option value="or">or</option> >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28784
:
123407
|
123409
|
123412
|
123413
|
123414
|
123416
|
123467
|
123468
|
123558
|
123559
|
123560
|
123561
|
123866
| 123867