Attachment 123952 Details for Bug 27944 – Bug 27944: (QA follow-up) Make staff home page show new article requests

[patch] Bug 27944: (QA follow-up) Make staff home page show new article requests

Bug-27944-QA-follow-up-Make-staff-home-page-show-n.patch (text/plain), 1.19 KB, created by Marcel de Rooy on 2021-08-18 12:29:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2021-08-18 12:29:08 UTC

Size: 1.19 KB

patch

obsolete

>From 43dcecd6e5c7f7667466a4a0db1379850d885380 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Tue, 10 Aug 2021 13:39:46 -0300
>Subject: [PATCH] Bug 27944: (QA follow-up) Make staff home page show new
> article requests
>Content-Type: text/plain; charset=utf-8
>
>As exposed on comment 29, the current code is showing the 'pending'
>requests when it should display 'requested' ones (i.e. the new ones).
>
>This patch changes that accordingly.
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> mainpage.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/mainpage.pl b/mainpage.pl
>index bc8dc88905..ab7089c8f3 100755
>--- a/mainpage.pl
>+++ b/mainpage.pl
>@@ -93,7 +93,7 @@ my $pending_borrower_modifications = Koha::Patron::Modifications->pending_count(
> my $pending_discharge_requests = Koha::Patron::Discharge::count({ pending => 1 });
> my $pending_article_requests = Koha::ArticleRequests->search_limited(
>     {
>-        status => Koha::ArticleRequest::Status::Pending,
>+        status => Koha::ArticleRequest::Status::Requested,
>         $branch ? ( 'me.branchcode' => $branch ) : (),
>     }
> )->count;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27944: 119020 | 119021 | 119022 | 120454 | 122673 | 122836 | 122837 | 122838 | 122839 | 122842 | 122843 | 122857 | 122984 | 122985 | 122986 | 122987 | 122988 | 122989 | 122990 | 123710 | 123711 | 123712 | 123943 | 123944 | 123945 | 123946 | 123947 | 123948 | 123949 | 123950 | 123951 | 123952 | 124966 | 124967 | 124968 | 124969 | 124970 | 124971 | 124972 | 124973 | 124974 | 124975 | 124976 | 125158 | 125544 | 125565 | 125567 | 125762 | 125813