Attachment 123954 Details for Bug 28346 – Bug 28346: (QA follow-up) Add `-action` for consistency

[patch] Bug 28346: (QA follow-up) Add `-action` for consistency

Bug-28346-QA-follow-up-Add--action-for-consistency.patch (text/plain), 4.36 KB, created by Katrin Fischer on 2021-08-18 12:40:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2021-08-18 12:40:53 UTC

Size: 4.36 KB

patch

obsolete

>From f2c4b0abc3653047a39f74047fb289ab166ed4be Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 18 Aug 2021 09:45:59 +0100
>Subject: [PATCH] Bug 28346: (QA follow-up) Add `-action` for consistency
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
>index 6bda4d6563..4b0452b2db 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
>@@ -105,16 +105,16 @@
>       [% IF account.amountoutstanding <= 0 %]<td class="credit" style="text-align: right;">[% ELSE %]<td class="debit" style="text-align: right;">[% END %][% account.amountoutstanding | $Price %]</td>
>       <td class="actions">
>         [% IF ( account.is_credit ) %]
>-          <a target="_blank" href="printfeercpt.pl?action=print&amp;accountlines_id=[% account.accountlines_id | uri %]" class="btn btn-default btn-xs receipt-print"><i class="fa fa-print"></i> Print</a>
>+          <a target="_blank" href="printfeercpt.pl?action=print&amp;accountlines_id=[% account.accountlines_id | uri %]" class="btn btn-default btn-xs receipt-print-action"><i class="fa fa-print"></i> Print</a>
>         [% ELSE %]
>-          <a target="_blank" href="printinvoice.pl?action=print&amp;accountlines_id=[% account.accountlines_id | uri %]" class="btn btn-default btn-xs invoice-print"><i class="fa fa-print"></i> Print</a>
>+          <a target="_blank" href="printinvoice.pl?action=print&amp;accountlines_id=[% account.accountlines_id | uri %]" class="btn btn-default btn-xs invoice-print-action"><i class="fa fa-print"></i> Print</a>
>         [% END %]
>         <a href="accountline-details.pl?accountlines_id=[% account.accountlines_id | uri %]" class="btn btn-default btn-xs details-action"><i class="fa fa-list"></i> Details</a>
>         [% IF account.is_debit && account.amountoutstanding > 0 %]
>             <a class="btn btn-default btn-xs pay-action" href="/cgi-bin/koha/members/paycollect.pl?borrowernumber=[% account.borrowernumber | html %]&pay_individual=1&debit_type_code=[% account.debit_type_code | html %]&amount=[% account.amount | html %]&amountoutstanding=[% account.amountoutstanding | html %]&description=[% account.description | html %]&itemnumber=[% account.itemnumber | html %]&accountlines_id=[% account.accountlines_id | html %]"><i class="fa fa-money"></i> Pay</a>
>         [% END %]
>         [% IF account.is_credit && account.status != 'VOID' %]
>-          <a href="boraccount.pl?action=void&amp;accountlines_id=[% account.accountlines_id | uri %]&amp;borrowernumber=[% account.borrowernumber | uri %]" class="btn btn-default btn-xs void"><i class="fa fa-ban"></i> Void payment</a>
>+          <a href="boraccount.pl?action=void&amp;accountlines_id=[% account.accountlines_id | uri %]&amp;borrowernumber=[% account.borrowernumber | uri %]" class="btn btn-default btn-xs void-action"><i class="fa fa-ban"></i> Void payment</a>
>         [% END %]
>         [% IF account.is_debit && account.amount == account.amountoutstanding && account.status != 'CANCELLED' && !(account.debit_type_code == 'PAYOUT') %]
>           <form method="post" action="/cgi-bin/koha/members/cancel-charge.pl">
>@@ -147,7 +147,7 @@
>         <td class="credit" style="text-align: right;">[% total | $Price %]</td>
>         <td>
>           [% IF CAN_user_updatecharges_payout %]
>-          <button type="button" data-toggle="modal" data-target="#issuePayoutModal" data-amount="[% total | $Price %]" class="btn btn-default btn-xs payout-amount"><i class="fa fa-money"></i> Payout amount</button>
>+          <button type="button" data-toggle="modal" data-target="#issuePayoutModal" data-amount="[% total | $Price %]" class="btn btn-default btn-xs payout-amount-action"><i class="fa fa-money"></i> Payout amount</button>
>         [% END %]
>         </td>
>     [% ELSE %]
>@@ -353,7 +353,7 @@
>                 $(this).toggleClass('filtered');
>             });
> 
>-            $(".void").on("click",function(e){
>+            $(".void-action").on("click",function(e){
>                 if( confirm( _("Are you sure you want to void this credit?") ) ) {
>                     return true;
>                 } else {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 28346: 120917 | 121108 | 121109 | 121118 | 121120 | 121121 | 121122 | 123923 | 123924 | 123953 | 123954