Bugzilla – Attachment 123963 Details for
Bug 21670
t/db_dependent/Plugins.t is failing randomly on Jenkins
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21670: Add debug to Plugins.t
Bug-21670-Add-debug-to-Pluginst.patch (text/plain), 1.98 KB, created by
Jonathan Druart
on 2021-08-18 14:51:10 UTC
(
hide
)
Description:
Bug 21670: Add debug to Plugins.t
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-08-18 14:51:10 UTC
Size:
1.98 KB
patch
obsolete
>From 221ba4076c53ab4910a1f4c90af81e39468d16e6 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 18 Aug 2021 16:50:03 +0200 >Subject: [PATCH] Bug 21670: Add debug to Plugins.t > >It's failing randomly (at least on Jenkins, cannot recreate locally). >Maybe the plugin is not actually installed? >--- > t/db_dependent/Koha/Plugins/Plugins.t | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/Plugins/Plugins.t b/t/db_dependent/Koha/Plugins/Plugins.t >index f49bd252fcc..7ae6664664a 100755 >--- a/t/db_dependent/Koha/Plugins/Plugins.t >+++ b/t/db_dependent/Koha/Plugins/Plugins.t >@@ -25,7 +25,7 @@ use File::Temp qw( tempdir tempfile ); > use FindBin qw($Bin); > use Module::Load::Conditional qw(can_load); > use Test::MockModule; >-use Test::More tests => 53; >+use Test::More tests => 55; > > use C4::Context; > use Koha::Database; >@@ -263,11 +263,12 @@ for my $pass ( 1 .. 2 ) { > ok( -f $plugins_dir . "/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm", "KitchenSink plugin installed successfully" ); > $INC{$pm_path} = $full_pm_path; # FIXME I do not really know why, but if this is moved before the $plugin constructor, it will fail with Can't locate object method "new" via package "Koha::Plugin::Com::ByWaterSolutions::KitchenSink" > Koha::Plugins->new( { enable_plugins => 1 } )->InstallPlugins(); >+ ok( -f $full_pm_path, "Koha::Plugins::Handler::delete works correctly (pass $pass)" ); > Koha::Plugins::Handler->delete({ class => "Koha::Plugin::Com::ByWaterSolutions::KitchenSink", enable_plugins => 1 }); > my $sth = C4::Context->dbh->table_info( undef, undef, $table, 'TABLE' ); > my $info = $sth->fetchall_arrayref; > is( @$info, 0, "Table $table does no longer exist" ); >- ok( !( -f $full_pm_path ), "Koha::Plugins::Handler::delete works correctly." ); >+ ok( !( -f $full_pm_path ), "Koha::Plugins::Handler::delete works correctly (pass $pass)" ); > } > > subtest 'output and output_html tests' => sub { >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21670
: 123963