Attachment 123978 Details for Bug 28885 – Bug 28885: Skip invalid biblios for OpacBrowseResults

[patch] Bug 28885: Skip invalid biblios for OpacBrowseResults

Bug-28885-Skip-invalid-biblios-for-OpacBrowseResul.patch (text/plain), 1.97 KB, created by Kyle M Hall (khall) on 2021-08-19 14:56:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2021-08-19 14:56:42 UTC

Size: 1.97 KB

patch

obsolete

>From f7b1e5337e3215aa18a4f31318836ac9636da685 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 19 Aug 2021 10:49:34 -0400
>Subject: [PATCH] Bug 28885: Skip invalid biblios for OpacBrowseResults
>
>If a record is deleted from Koha, but is for some reason not deleted from the search indexes, OpacBrowseResults can cause an ISE if the deleted record is in the search results for any given item. OpacBrowseResults loops through the search results, and checks if there is a biblionumber, but does *not* check to see if a result was pulled from the database for that biblionumber. It simply assumes the result must exist.
>
>We should be checking to ensure the biblionumber was valid before operating on the biblio object.
>
>Test Plan:
>1) Use zebra for searching
>2) Disable koha-indexer
>3) Enable OpacBrowseResults
>4) Perform a search
>5) Delete an item in the search results
>6) View on of the remaining items in the search results
>7) Note the error
>8) Apply this patch
>9) Restart plack
>10) Reload the page
>11) The error should be gone!
>---
> opac/opac-detail.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl
>index 55a326fe37..a9eb913f00 100755
>--- a/opac/opac-detail.pl
>+++ b/opac/opac-detail.pl
>@@ -526,6 +526,7 @@ if ($session->param('busc')) {
>     for (my $j = 0; $j < @arrBiblios; $j++) {
>         next unless ($arrBiblios[$j]);
>         $dataBiblioPaging = Koha::Biblios->find( $arrBiblios[$j] ) if ($arrBiblios[$j] != $biblionumber);
>+        next unless $dataBiblioPaging;
>         push @listResults, {index => $j + 1 + $offset, biblionumber => $arrBiblios[$j], title => ($arrBiblios[$j] == $biblionumber)?'':$dataBiblioPaging->title, author => ($arrBiblios[$j] != $biblionumber && $dataBiblioPaging->author)?$dataBiblioPaging->author:'', url => ($arrBiblios[$j] == $biblionumber)?'':'opac-detail.pl?biblionumber=' . $arrBiblios[$j]};
>     }
>     $template->param('listResults' => \@listResults) if (@listResults);
>-- 
>2.30.1 (Apple Git-130)

Actions: View | Diff | Splinter Review

Attachments on bug 28885: 123978 | 124009 | 124252