Bugzilla – Attachment 123995 Details for
Bug 28883
Koha::Objects->_new_from_dbic doesn't work correctly in list context
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28883: [OPTIONAL] (follow-up) Should we force scalar context within map?
Bug-28883-OPTIONAL-follow-up-Should-we-force-scala.patch (text/plain), 954 bytes, created by
Marcel de Rooy
on 2021-08-20 08:48:25 UTC
(
hide
)
Description:
Bug 28883: [OPTIONAL] (follow-up) Should we force scalar context within map?
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2021-08-20 08:48:25 UTC
Size:
954 bytes
patch
obsolete
>From 5ef524f950272f19a574746e4a26df324c9b629e Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 20 Aug 2021 08:43:01 +0000 >Subject: [PATCH] Bug 28883: [OPTIONAL] (follow-up) Should we force scalar > context within map? >Content-Type: text/plain; charset=utf-8 > >Currently, this does not seem necessary. Somehow it feels better imo. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > Koha/Objects.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Objects.pm b/Koha/Objects.pm >index 86de594469..e56378b684 100644 >--- a/Koha/Objects.pm >+++ b/Koha/Objects.pm >@@ -528,7 +528,7 @@ wraps the DBIC object in a corresponding Koha object > sub _wrap { > my ( $self, @dbic_rows ) = @_; > >- my @objects = map { $self->object_class->_new_from_dbic( $_ ) } @dbic_rows; >+ my @objects = map { scalar $self->object_class->_new_from_dbic( $_ ) } @dbic_rows; > > return @objects; > } >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28883
:
123976
|
123977
|
123980
|
123981
|
123992
|
123993
|
123994
|
123995
|
124181
|
124420