Attachment 12406 Details for Bug 8700 – [SIGNED-OFF] Bug 8700 - RESERVESLIP fields not being replaced correctly

[patch] [SIGNED-OFF] Bug 8700 - RESERVESLIP fields not being replaced correctly

SIGNED-OFF-Bug-8700---RESERVESLIP-fields-not-being.patch (text/plain), 1.52 KB, created by Marc Véron on 2012-09-21 05:31:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Véron

Created: 2012-09-21 05:31:14 UTC

Size: 1.52 KB

patch

obsolete

>From a0d45c019ccdf10665c85eda47efa30d2c968705 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 29 Aug 2012 08:44:26 -0400
>Subject: [PATCH] [SIGNED-OFF] Bug 8700 - RESERVESLIP fields not being replaced correctly
>Content-Type: text/plain; charset="utf-8"
>
>The slip RESERVESLIP is not replacing fields correctly.
>C4::Reserves::ReserveSlip calls C4::Letters::GetPreparedLetter,
>and passes the $reserve hashref to it for each table except branches
>( which is passed the branchcode ). The problem is, if you pass a
>hashref for a table, it uses that hashref for the replacing, rather
>than looking up the data from the database.
>
>Fixed by passing the correct keys for each of the tables requested.
>
>Signed-off-by: Marc Veron <veron@veron.ch>
>
>Tested following the test plan.
>Could reproduce the bug.
>After applying the patch slip printed as expected.
>---
> C4/Reserves.pm |    6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/C4/Reserves.pm b/C4/Reserves.pm
>index 585d1e5..1dc6f72 100644
>--- a/C4/Reserves.pm
>+++ b/C4/Reserves.pm
>@@ -2081,9 +2081,9 @@ sub ReserveSlip {
>         tables => {
>             'reserves'    => $reserve,
>             'branches'    => $reserve->{branchcode},
>-            'borrowers'   => $reserve,
>-            'biblio'      => $reserve,
>-            'items'       => $reserve,
>+            'borrowers'   => $reserve->{borrowernumber},
>+            'biblio'      => $reserve->{biblionumber},
>+            'items'       => $reserve->{itemnumber},
>         },
>     );
> }
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 8700: 11877 | 12406