Attachment 124113 Details for Bug 28906 – Bug 28906: Make Koha::Items->filter_by_visible_in_opac honour list context

[patch] Bug 28906: Make Koha::Items->filter_by_visible_in_opac honour list context

Bug-28906-Make-KohaItems-filterbyvisibleinopac-hon.patch (text/plain), 969 bytes, created by Tomás Cohen Arazi (tcohen) on 2021-08-26 12:38:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2021-08-26 12:38:21 UTC

Size: 969 bytes

patch

obsolete

>From 2237dc58f7f4db5f7026820e9526c13c76450593 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 26 Aug 2021 09:35:39 -0300
>Subject: [PATCH] Bug 28906: Make Koha::Items->filter_by_visible_in_opac honour
> list context
>
>This patch makes the method honour list context.
>
>To test:
>1. Apply the regression tests patch
>2. Run:
>   $ kshell
>  k$ prove t/db_dependent/Koha/Items.t
>=> FAIL: Tests fail! It returns [Koha::Items]. Boo!
>3. Apply this patch
>4. Repeat 2
>=> SUCCESS: Tests pass!
>5. Sign off :-D
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> Koha/Items.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/Items.pm b/Koha/Items.pm
>index 2643223d3b..15fdbfde77 100644
>--- a/Koha/Items.pm
>+++ b/Koha/Items.pm
>@@ -89,7 +89,7 @@ sub filter_by_visible_in_opac {
>         $result = $result->filter_out_lost;
>     }
> 
>-    return $result;
>+    return $result->search;
> }
> 
> =head3 filter_out_lost
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 28906: 124112 | 124113 | 124114 | 124115 | 125035 | 125036 | 125037 | 125258 | 125259 | 125260