Attachment 124114 Details for Bug 28906 – Bug 28906: (26223 follow-up) Remove use of as_list

[patch] Bug 28906: (26223 follow-up) Remove use of as_list

Bug-28906-26223-follow-up-Remove-use-of-aslist.patch (text/plain), 1.23 KB, created by Tomás Cohen Arazi (tcohen) on 2021-08-26 12:44:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2021-08-26 12:44:40 UTC

Size: 1.23 KB

patch

obsolete

>From 9e7af6630f9e7019325798749cf4ff772e4ff000 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 26 Aug 2021 09:41:48 -0300
>Subject: [PATCH] Bug 28906: (26223 follow-up) Remove use of as_list
>
>This bug makes Koha::Items->filter_by_visible_in_opac honour list
>context, so this explicit call is not needed.
>
>To test:
>1. Pick a biblio in the OPAC
>2. Go to the ISBD view
>=> SUCCESS: It renders correctly
>3. Apply this patch and restart Plack
>4. Refresh the ISBD view page
>=> SUCCESS: It doesn't break!
>5. Sign off :-D
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> opac/opac-ISBDdetail.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/opac/opac-ISBDdetail.pl b/opac/opac-ISBDdetail.pl
>index 47fcb5e852..41119b3521 100755
>--- a/opac/opac-ISBDdetail.pl
>+++ b/opac/opac-ISBDdetail.pl
>@@ -99,7 +99,7 @@ unless ( $patron and $patron->category->override_hidden_items ) {
> }
> 
> my $record = $biblio->metadata->record;
>-my @items  = $biblio->items->filter_by_visible_in_opac({ patron => $patron })->as_list;
>+my @items  = $biblio->items->filter_by_visible_in_opac({ patron => $patron });
> 
> my $record_processor = Koha::RecordProcessor->new(
>     {   filters => [ 'EmbedItems', 'ViewPolicy' ],
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 28906: 124112 | 124113 | 124114 | 124115 | 125035 | 125036 | 125037 | 125258 | 125259 | 125260