Bugzilla – Attachment 124118 Details for
Bug 28870
Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28870: Use Email::Address->parse
Bug-28870-Use-EmailAddress-parse.patch (text/plain), 733 bytes, created by
Jonathan Druart
on 2021-08-26 15:14:11 UTC
(
hide
)
Description:
Bug 28870: Use Email::Address->parse
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-08-26 15:14:11 UTC
Size:
733 bytes
patch
obsolete
>From 75372a5e3eeb1bdd5a143f3e0a2cc71fb3a5f96f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 26 Aug 2021 17:13:41 +0200 >Subject: [PATCH] Bug 28870: Use Email::Address->parse > >--- > Koha/Email.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/Koha/Email.pm b/Koha/Email.pm >index db897e07896..4806126217c 100644 >--- a/Koha/Email.pm >+++ b/Koha/Email.pm >@@ -184,7 +184,8 @@ Return true is the email address passed in parameter is valid following RFC 2822 > > sub is_valid { > my ( $class, $email ) = @_; >- return ($email =~ m{$Email::Address::mailbox}) ? 1 : 0; >+ my @addrs = Email::Address->parse($email); >+ return @addrs ? 1 : 0; > } > > 1; >-- >2.25.1
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=124118">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28870
:
124002
|
124003
|
124004
|
124117
|
124118
|
124119
|
124178
|
124179
|
124180
|
124183
|
124184
|
124185
|
124752
|
124753
|
124754
|
124755
|
124756
|
124757
|
124762
|
124763
|
124764
|
124765
|
124766
|
124767
|
127521
|
127522
|
127523
|
127524
|
127525
|
127526
|
127745
|
127746
|
127747
|
127748
|
127749
|
127750