Attachment 124162 Details for Bug 28744 – Bug 28744: Regression tests

[patch] Bug 28744: Regression tests

Bug-28744-Regression-tests.patch (text/plain), 2.00 KB, created by Marcel de Rooy on 2021-08-27 09:54:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2021-08-27 09:54:30 UTC

Size: 2.00 KB

patch

obsolete

>From 2e2be150892ed89dd5779a1c60d82ea0223ee187 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 23 Jul 2021 00:35:49 -0300
>Subject: [PATCH] Bug 28744: Regression tests
>Content-Type: text/plain; charset=utf-8
>
>This patch adds tests for the following cases:
>- to_api_mapping not defined
>- to_api_mapping returning an empty hashref
>
>To test:
>1. Apply this patch
>2. Run:
>   $ kshell
>  k$ prove t/db_dependent/Koha/Object.t
>=> FAIL: Tests fail :-(
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/db_dependent/Koha/Object.t | 26 +++++++++++++++++++++++++-
> 1 file changed, 25 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Object.t b/t/db_dependent/Koha/Object.t
>index 64d3f1d9ea..6e30eeb396 100755
>--- a/t/db_dependent/Koha/Object.t
>+++ b/t/db_dependent/Koha/Object.t
>@@ -390,7 +390,7 @@ subtest "to_api_mapping() tests" => sub {
> 
> subtest "from_api_mapping() tests" => sub {
> 
>-    plan tests => 3;
>+    plan tests => 5;
> 
>     $schema->storage->txn_begin;
> 
>@@ -449,6 +449,30 @@ subtest "from_api_mapping() tests" => sub {
>         'Fresh mapping loaded'
>     );
> 
>+    $city_class->unmock( 'to_api_mapping');
>+    # $city_class->mock( 'to_api_mapping', sub { return {}; });
>+    $city_class->mock( 'to_api_mapping', undef );
>+
>+    # Get a fresh object
>+    $city = $builder->build_object({ class => 'Koha::Cities' });
>+    is_deeply(
>+        $city->from_api_mapping,
>+        {},
>+        'No to_api_mapping then empty hashref'
>+    );
>+
>+    $city_class->unmock( 'to_api_mapping');
>+    # $city_class->mock( 'to_api_mapping', sub { return {}; });
>+    $city_class->mock( 'to_api_mapping', sub { return; } );
>+
>+    # Get a fresh object
>+    $city = $builder->build_object({ class => 'Koha::Cities' });
>+    is_deeply(
>+        $city->from_api_mapping,
>+        {},
>+        'Empty to_api_mapping then empty hashref'
>+    );
>+
>     $schema->storage->txn_rollback;
> };
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28744: 123069 | 123070 | 123152 | 123153 | 124162 | 124163 | 124189 | 124190 | 124238 | 124239