Attachment 124180 Details for Bug 28870 – Bug 28870: non-FQDN addresses are valid

[patch] Bug 28870: non-FQDN addresses are valid

Bug-28870-non-FQDN-addresses-are-valid.patch (text/plain), 1.82 KB, created by Tomás Cohen Arazi (tcohen) on 2021-08-27 13:04:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2021-08-27 13:04:45 UTC

Size: 1.82 KB

patch

obsolete

>From e32a51d882881ee2e03b992432c0794b330fc2fc Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 26 Aug 2021 17:21:32 +0200
>Subject: [PATCH] Bug 28870: non-FQDN addresses are valid
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> opac/opac-memberentry.pl | 2 +-
> t/Koha/Email.t           | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl
>index 1ae2ebe281..cce33d8c8b 100755
>--- a/opac/opac-memberentry.pl
>+++ b/opac/opac-memberentry.pl
>@@ -439,7 +439,7 @@ sub CheckForInvalidFields {
>     my $borrower = shift;
>     my @invalidFields;
>     if ($borrower->{'email'}) {
>-        unless ( Koha::Email->is_valid($borrower->{email}) {
>+        unless ( Koha::Email->is_valid($borrower->{email}) ) {
>             push(@invalidFields, "email");
>         } elsif ( C4::Context->preference("PatronSelfRegistrationEmailMustBeUnique") ) {
>             my $patrons_with_same_email = Koha::Patrons->search( # FIXME Should be search_limited?
>diff --git a/t/Koha/Email.t b/t/Koha/Email.t
>index f47a0908cd..a329950a37 100755
>--- a/t/Koha/Email.t
>+++ b/t/Koha/Email.t
>@@ -255,10 +255,10 @@ subtest 'is_valid' => sub {
>     is(Koha::Email->is_valid('FrÃ³m <from@example.com>'), 1);
>     is(Koha::Email->is_valid('from@example.com'), 1);
>     is(Koha::Email->is_valid('<from@example.com>'), 1);
>+    is(Koha::Email->is_valid('root@localhost'), 1); # See bug 28017
> 
>     is(Koha::Email->is_valid('<from@frÃ³m.com>'), 0); # "In accordance with RFC 822 and its descendants, this module demands that email addresses be ASCII only"
>     isnt(Koha::Email->is_valid('@example.com'), 1);
>     isnt(Koha::Email->is_valid('example.com'), 1);
>-    isnt(Koha::Email->is_valid('root@localhost'), 1);
>     isnt(Koha::Email->is_valid('from'), 1);
> };
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 28870: 124002 | 124003 | 124004 | 124117 | 124118 | 124119 | 124178 | 124179 | 124180 | 124183 | 124184 | 124185 | 124752 | 124753 | 124754 | 124755 | 124756 | 124757 | 124762 | 124763 | 124764 | 124765 | 124766 | 124767 | 127521 | 127522 | 127523 | 127524 | 127525 | 127526 | 127745 | 127746 | 127747 | 127748 | 127749 | 127750