Attachment 124221 Details for Bug 28810 – Bug 28810: replace housebould detail inputs with textarea

[patch] Bug 28810: replace housebould detail inputs with textarea

Bug-28810-replace-housebould-detail-inputs-with-te.patch (text/plain), 6.86 KB, created by Katrin Fischer on 2021-08-29 11:11:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2021-08-29 11:11:27 UTC

Size: 6.86 KB

patch

obsolete

>From cf7c88d02314073935ca1c68e29eeaa767e1fae4 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Tue, 3 Aug 2021 21:24:17 +0000
>Subject: [PATCH] Bug 28810: replace housebould detail inputs with textarea
>
>To test:
>1. apply patch
>2. enable housebound module
>3. go to a patron and look at the housebound tab
>4. Edit the detials.
>5. The preferred materials, subjects, authors, referral, and note inputs should be replace with much larger textareas.
>6. You should now be able to added line breaks, so fill out each of the fields adding some line breaks. I added something like:
>Fiction authors: Frank Herbert
>Non-fiction authors: Malcolm Gladwell
>
>7. Save changes
>8. Now when you look at the housebound details those line breaks should be preserved and much easier to read.
>
>Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../prog/en/modules/members/housebound.tt          | 45 ++++++++++------------
> 1 file changed, 20 insertions(+), 25 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt
>index f494bd8cab..51488f2d59 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt
>@@ -151,46 +151,41 @@
>                     <li>
>                       <label for="fav_itemtypes">Preferred materials:</label>
>                       [% IF ( housebound_profile ) %]
>-                        <input id="fav_itemtypes" type="text" size="50" name="fav_itemtypes"
>-                               value="[% housebound_profile.fav_itemtypes | html %]">
>+                        <textarea id="fav_itemtypes" name="fav_itemtypes" cols="110" rows="10">[% housebound_profile.fav_itemtypes | html  %]</textarea>
>                       [% ELSE %]
>-                        <input id="fav_itemtypes" type="text" value="" size="50" name="fav_itemtypes">
>+                        <textarea id="fav_itemtypes" name="fav_itemtypes" cols="110" rows="10"></textarea>
>                       [% END %]
>                     </li>
>                     <li>
>                       <label for="fav_subjects">Subjects:</label>
>                       [% IF ( housebound_profile ) %]
>-                        <input id="fav_subjects" type="text" size="50" name="fav_subjects"
>-                               value="[% housebound_profile.fav_subjects | html %]">
>+                        <textarea id="fav_subjects" name="fav_subjects" cols="110" rows="10">[% housebound_profile.fav_subjects | html %]</textarea>
>                       [% ELSE %]
>-                        <input id="fav_subjects" type="text" value="" size="50" name="fav_subjects">
>+                        <textarea id="fav_subjects" name="fav_subjects" cols="110" rows="10"></textarea>
>                       [% END %]
>                     </li>
>                     <li>
>                       <label for="fav_authors">Authors:</label>
>                       [% IF ( housebound_profile ) %]
>-                        <input id="fav_authors" type="text" size="50" name="fav_authors"
>-                               value="[% housebound_profile.fav_authors | html %]">
>+                        <textarea id="fav_authors" name="fav_authors" cols="110" rows="10">[% housebound_profile.fav_authors | html %]</textarea>
>                       [% ELSE %]
>-                        <input id="fav_authors" type="text" value="" size="50" name="fav_authors">
>+                        <textarea id="fav_authors" name="fav_authors" cols="110" rows="10"></textarea>
>                       [% END %]
>                     </li>
>                     <li>
>                       <label for="referral">Referral:</label>
>                       [% IF ( housebound_profile ) %]
>-                        <input id="referral" type="text" size="50" name="referral"
>-                               value="[% housebound_profile.referral | html %]">
>+                        <textarea id="referral" name="referral" cols="110" rows="10">[% housebound_profile.referral | html %]</textarea>
>                       [% ELSE %]
>-                        <input id="referral" type="text" value="" size="50" name="referral">
>+                        <textarea id="referral" name="referral" cols="110" rows="10"></textarea>
>                       [% END %]
>                     </li>
>                     <li>
>                       <label for="notes">Notes:</label>
>                       [% IF ( housebound_profile ) %]
>-                        <input id="notes" type="text" size="50" name="notes"
>-                               value="[% housebound_profile.notes | html %]">
>+                        <textarea id="notes" name="notes" cols="110" rows="10">[% housebound_profile.notes | html %]</textarea>
>                       [% ELSE %]
>-                        <input id="notes" type="text" value="" size="50" name="notes">
>+                        <textarea id="notes" name="notes" cols="110" rows="10"></textarea>
>                       [% END %]
>                     </li>
>                   </ol>
>@@ -360,24 +355,24 @@
>                     [% AuthorisedValues.GetByCode( 'HSBND_FREQ', housebound_profile.frequency, 0 ) || housebound_profile.frequency | html %]
>                   </li>
>                   <li>
>-                    <span class="label">Material:</span>
>-                    [% housebound_profile.fav_itemtypes | html %]
>+                    <span class="label">Material:</span><br />
>+                    [% housebound_profile.fav_itemtypes | html | html_line_break %]
>                   </li>
>                   <li>
>-                    <span class="label">Subjects:</span>
>-                    [% housebound_profile.fav_subjects | html %]
>+                    <span class="label">Subjects:</span><br />
>+                    [% housebound_profile.fav_subjects | html | html_line_break %]
>                   </li>
>                   <li>
>-                    <span class="label">Authors:</span>
>-                    [% housebound_profile.fav_authors | html %]
>+                    <span class="label">Authors:</span><br />
>+                    [% housebound_profile.fav_authors | html | html_line_break %]
>                   </li>
>                   <li>
>-                    <span class="label">Referral:</span>
>-                    [% housebound_profile.referral | html %]
>+                    <span class="label">Referral:</span><br />
>+                    [% housebound_profile.referral | html | html_line_break %]
>                   </li>
>                   <li>
>-                    <span class="label">Notes:</span>
>-                    [% housebound_profile.notes | html %]
>+                    <span class="label">Notes:</span><br />
>+                    [% housebound_profile.notes | html | html_line_break %]
>                   </li>
>                 </ol>
>                 <div class="action">
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 28810: 123445 | 123455 | 124221