Attachment 124225 Details for Bug 28373 – Bug 28373: (follow-up) QA fixes

[patch] Bug 28373: (follow-up) QA fixes

Bug-28373-follow-up-QA-fixes.patch (text/plain), 1.85 KB, created by Katrin Fischer on 2021-08-29 11:49:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2021-08-29 11:49:54 UTC

Size: 1.85 KB

patch

obsolete

>From c0bdab639cd22c985caccd5f6c34b52d8bb393d2 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 23 Aug 2021 14:12:26 +0000
>Subject: [PATCH] Bug 28373: (follow-up) QA fixes
>
>Use fully qualified subroutine name
>Don't return explicit undef
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> t/Search.t | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
>diff --git a/t/Search.t b/t/Search.t
>index 64b6e50dc6..11d6eb54b7 100755
>--- a/t/Search.t
>+++ b/t/Search.t
>@@ -181,9 +181,10 @@ subtest "searchResults PassItemMarcToXSLT test" => sub {
>     t::lib::Mocks::mock_preference('marcflavour','MARC21');
>     my $mock_xslt = Test::MockModule->new("C4::Search");
>     $mock_xslt->mock( XSLTParse4Display => sub {
>-       my (undef, $record) = @_;
>+        my $params = shift;
>+        my $record = $params->{record};
>         warn $record->field('952') ? "Item here" : "No item";
>-        return undef;
>+        return;
>     });
> 
>     my $builder = t::lib::TestBuilder->new;
>@@ -194,13 +195,13 @@ subtest "searchResults PassItemMarcToXSLT test" => sub {
> 
>     t::lib::Mocks::mock_preference('PassItemMarcToXSLT','1');
> 
>-    warnings_like { searchResults({ interface => "opac" },"test",1,1,0,0,[ $record->as_xml_record ] ,undef) }
>+    warnings_like { C4::Search::searchResults({ interface => "opac" },"test",1,1,0,0,[ $record->as_xml_record ] ,undef) }
>         [qr/Item here/],
>         "Item field returned from default XSLT if pref set";
> 
>     t::lib::Mocks::mock_preference('PassItemMarcToXSLT','0');
> 
>-    warnings_like { searchResults({ interface => "opac" },"test",1,1,0,0,[ $record->as_xml_record ] ,undef) }
>+    warnings_like { C4::Search::searchResults({ interface => "opac" },"test",1,1,0,0,[ $record->as_xml_record ] ,undef) }
>         [qr/No item/],
>         "Item field returned from default XSLT if pref set";
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 28373: 121115 | 121610 | 121611 | 122614 | 122615 | 122616 | 122628 | 122629 | 122630 | 124019 | 124222 | 124223 | 124224 | 124225 | 124226 | 124254 | 124255 | 124495 | 124496 | 124686