Attachment 124227 Details for Bug 28838 – Bug 28838: add unique IDs to sco-main.tt impossible errors

[patch] Bug 28838: add unique IDs to sco-main.tt impossible errors

Bug-28838-add-unique-IDs-to-sco-maintt-impossible-.patch (text/plain), 6.17 KB, created by Katrin Fischer on 2021-08-29 11:54:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2021-08-29 11:54:35 UTC

Size: 6.17 KB

patch

obsolete

>From 44afca10c4cca101ef5485e2f4dcf4cb2e2588be Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Tue, 10 Aug 2021 14:18:23 +0000
>Subject: [PATCH] Bug 28838: add unique IDs to sco-main.tt impossible errors
>
>To test:
>1. Apply patch
>2. Go SCO and try to checkout some items that will generate some of the
> following errors:
>
>The system does not recognize this barcode.
>You have checked out too many items and can't check out any more.
>This item is checked out to someone else.
>You cannot renew this item again.
>This item is not for loan.
>You owe the library [% DEBT | $Price %] and cannot check out.
>This item has been withdrawn from the collection.
>This item is restricted.
>This item is on hold for another patron.
>This item belongs to another branch.
>Your account has expired.
>Your account has been suspended.
>This card has been declared lost.
>Your contact information seems to be incomplete.
>Due date is not valid.
>Item must be checked out at a circulation desk.
>
>3. The display should be exactly as it was without the patch but if you
> use the browsers dev tools you should be able to inscept each error
> message and see that it is now wrapped in a with an ID.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 34 +++++++++++-----------
> 1 file changed, 17 insertions(+), 17 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
>index 40521d7e00..2e5d352e43 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
>@@ -60,39 +60,39 @@
> 
> 
> [% IF ( circ_error_UNKNOWN_BARCODE ) %]
>- The system does not recognize this barcode.
>+ The system does not recognize this barcode.
> [% ELSIF ( circ_error_max_loans_allowed ) %]
>- You have checked out too many items and can't check out any more.
>+ You have checked out too many items and can't check out any more.
> [% ELSIF ( circ_error_ISSUED_TO_ANOTHER ) %]
>- This item is checked out to someone else.
>+ This item is checked out to someone else.
> [% ELSIF ( circ_error_NO_MORE_RENEWALS ) %]
>- You cannot renew this item again.
>+ You cannot renew this item again.
> [% ELSIF ( circ_error_NOT_FOR_LOAN ) %]
>- This item is not for loan.
>+ This item is not for loan.
> [% ELSIF ( circ_error_DEBT ) %]
>- You owe the library [% DEBT | $Price %] and cannot check out.
>+ You owe the library [% DEBT | $Price %] and cannot check out.
> [% ELSIF ( circ_error_WTHDRAWN ) %]
>- This item has been withdrawn from the collection.
>+ This item has been withdrawn from the collection.
> [% ELSIF ( circ_error_RESTRICTED ) %]
>- This item is restricted.
>+ This item is restricted.
> [% ELSIF ( circ_error_RESERVED ) %]
>- This item is on hold for another patron.
>+ This item is on hold for another patron.
> [% ELSIF ( circ_error_ITEMNOTSAMEBRANCH ) %]
>- This item belongs to another branch.
>+ This item belongs to another branch.
> [% ELSIF ( circ_error_EXPIRED ) %]
>- Your account has expired.
>+ Your account has expired.
> [% ELSIF ( circ_error_DEBARRED ) %]
>- Your account has been suspended.
>+ Your account has been suspended.
> [% ELSIF ( circ_error_CARD_LOST ) %]
>- This card has been declared lost.
>+ This card has been declared lost.
> [% ELSIF ( circ_error_GNA ) %]
>- Your contact information seems to be incomplete.
>+ Your contact information seems to be incomplete.
> [% ELSIF ( circ_error_INVALID_DATE ) %]
>- Due date is not valid.
>+ Due date is not valid.
> [% ELSIF ( circ_error_ADDITIONAL_MATERIALS ) %]
>- Item must be checked out at a circulation desk.
>+ Item must be checked out at a circulation desk.
> [% END %]
>- Please see a member of the library staff.
>+ Please see a member of the library staff.
> 
> 
> [% IF ( returnitem && Koha.Preference('SCOAllowCheckin') ) %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 28838: 123700 | 123781 | 124227