Bugzilla – Attachment 124235 Details for
Bug 7703
Don't block bulk hold action on search results if some items can't be placed on hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7703: (follow-up) Treat no items like none available
Bug-7703-follow-up-Treat-no-items-like-none-availa.patch (text/plain), 5.23 KB, created by
Katrin Fischer
on 2021-08-29 15:21:56 UTC
(
hide
)
Description:
Bug 7703: (follow-up) Treat no items like none available
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2021-08-29 15:21:56 UTC
Size:
5.23 KB
patch
obsolete
>From c3cbe8563d1debe281a6fe223e1f3644c66a635e Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 6 Aug 2021 12:54:46 +0000 >Subject: [PATCH] Bug 7703: (follow-up) Treat no items like none available > >This patch modifies the holds template so that during the >multi-hold process, titles with no items attached are treated the same >way as titles with no items available (items exist but cannot be place >don hold): > > - The row showing such a record will say "No items are available to be > placed on hold." > - The pickup location dropdown will be hidden. > >To test, follow the previous test plan and confirm that these change are >reflected. Now that the pickup location field isn't present for titles >without items you should be able to complete the holds process. > >Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 2e5fbeaf1c..f54ac0d32a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -305,7 +305,7 @@ > [% IF ( biblioloo.alreadyres ) %] > <ul> > [% ELSE %] >- [% IF ( biblioloo.none_avail ) %] >+ [% IF ( biblioloo.none_avail || biblioloo.noitems ) %] > <ul> > [% END %] > [% END %] >@@ -316,14 +316,14 @@ > <strong>already has a hold</strong> on this item > </li> > [% END %] >- [% IF ( biblioloo.none_avail ) %] >+ [% IF ( biblioloo.none_avail || biblioloo.noitems ) %] > <li> <strong>No items are available</strong> to be placed on hold</li> > [% END %] > > [% IF ( biblioloo.alreadyres ) %] > </ul> > [% ELSE %] >- [% IF ( biblioloo.none_avail ) %] >+ [% IF ( biblioloo.none_avail || biblioloo.noitems ) %] > </ul> > [% END %] > [% END %] >@@ -818,7 +818,7 @@ > [% IF ( biblioloo.alreadyres ) %] > <ul> > [% ELSE %] >- [% IF ( biblioloo.none_avail ) %] >+ [% IF ( biblioloo.none_avail || biblioloo.noitems ) %] > <ul> > [% END %] > [% END %] >@@ -829,20 +829,20 @@ > <strong>already has a hold</strong> on this item > </li> > [% END %] >- [% IF ( biblioloo.none_avail ) %] >+ [% IF ( biblioloo.none_avail || biblioloo.noitems ) %] > <li> <strong>No items are available</strong> to be placed on hold</li> > [% END %] > > [% IF ( biblioloo.alreadyres ) %] > </ul> > [% ELSE %] >- [% IF ( biblioloo.none_avail ) %] >+ [% IF ( biblioloo.none_avail || biblioloo.noitems ) %] > </ul> > [% END %] > [% END %] > </td> > <td> >- [% UNLESS ( biblioloo.none_avail ) %] >+ [% UNLESS ( biblioloo.none_avail || biblioloo.noitems ) %] > <select name="pickup_[% biblioloo.biblionumber | html %]" > class="multi_pickup_select" > data-biblio-id="[% biblioloo.biblionumber | html %]" >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7703
:
9613
|
14360
|
14435
|
15290
|
19114
|
19115
|
28144
|
52166
|
52167
|
52168
|
52295
|
52296
|
123575
|
123576
|
123577
|
123812
|
123813
|
123814
|
124233
|
124234
| 124235