Bugzilla – Attachment 124321 Details for
Bug 20256
Add ability to limit editing of items to home library or library group
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20256: (follow-up) Don't filter if no libraries are restricted
Bug-20256-follow-up-Dont-filter-if-no-libraries-ar.patch (text/plain), 1.15 KB, created by
Nick Clemens (kidclamp)
on 2021-09-01 12:07:36 UTC
(
hide
)
Description:
Bug 20256: (follow-up) Don't filter if no libraries are restricted
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2021-09-01 12:07:36 UTC
Size:
1.15 KB
patch
obsolete
>From fce57c870fb92b30a0040a54caaa9ed7ac65d3ca Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 1 Sep 2021 12:06:49 +0000 >Subject: [PATCH] Bug 20256: (follow-up) Don't filter if no libraries are > restricted > >--- > cataloguing/additem.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl >index 640ef222f0..35db3c2476 100755 >--- a/cataloguing/additem.pl >+++ b/cataloguing/additem.pl >@@ -194,7 +194,7 @@ sub generate_subfield_form { > elsif ( $subfieldlib->{authorised_value} eq "branches" ) { > my @allowed = $patron->libraries_where_can_edit_items; > foreach my $thisbranch (@$branches) { >- next unless any { /^$thisbranch->{branchcode}$/ } @allowed; >+ next unless !@allowed || any { /^$thisbranch->{branchcode}$/ } @allowed; > push @authorised_values, $thisbranch->{branchcode}; > $authorised_lib{$thisbranch->{branchcode}} = $thisbranch->{branchname}; > $value = $thisbranch->{branchcode} if $thisbranch->{selected} && !$value; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20256
:
87226
|
87227
|
87228
|
87229
|
87230
|
87231
|
87232
|
87233
|
87262
|
87263
|
87264
|
87265
|
87266
|
87267
|
87268
|
87269
|
87270
|
88537
|
88539
|
88541
|
88542
|
88543
|
88544
|
88545
|
88546
|
88547
|
88632
|
88702
|
88703
|
88704
|
88705
|
88935
|
88936
|
96015
|
96016
|
96017
|
96018
|
96019
|
96020
|
96021
|
96022
|
96023
|
96024
|
96025
|
96026
|
96027
|
96028
|
96029
|
96030
|
96031
|
96032
|
96033
|
102622
|
102623
|
102624
|
102625
|
102626
|
102627
|
102628
|
102629
|
102630
|
102631
|
102632
|
102633
|
102634
|
102635
|
102636
|
102637
|
102638
|
102639
|
102640
|
102641
|
102642
|
102703
|
102704
|
102705
|
102706
|
102707
|
102708
|
102709
|
102710
|
102711
|
102712
|
102713
|
102714
|
102715
|
102716
|
102717
|
102718
|
102719
|
102720
|
102721
|
102722
|
102732
|
102733
|
102734
|
102735
|
102736
|
102737
|
102738
|
102739
|
102740
|
102741
|
102742
|
102743
|
102744
|
102745
|
102746
|
102747
|
102748
|
102749
|
102750
|
102751
|
107312
|
107313
|
107314
|
107315
|
107316
|
107317
|
107318
|
107319
|
107320
|
107321
|
107322
|
107323
|
107324
|
107325
|
107326
|
107327
|
107328
|
107329
|
107330
|
108851
|
108852
|
108853
|
108854
|
108855
|
108856
|
108857
|
108858
|
108859
|
108860
|
108861
|
108862
|
108863
|
108864
|
108865
|
108866
|
108867
|
108868
|
108869
|
108870
|
109939
|
110005
|
113706
|
113707
|
113708
|
113709
|
113710
|
113711
|
113712
|
113713
|
113714
|
113715
|
113716
|
113717
|
113718
|
113719
|
113720
|
113721
|
113722
|
113723
|
113724
|
113725
|
113726
|
113727
|
113728
|
116042
|
116043
|
116044
|
116045
|
116046
|
116047
|
116048
|
116049
|
116050
|
116051
|
116052
|
116053
|
116054
|
116055
|
116056
|
116057
|
116058
|
116059
|
116060
|
116061
|
116062
|
116063
|
116064
|
120055
|
120056
|
120057
|
120058
|
120059
|
120060
|
120061
|
120062
|
120063
|
120064
|
120065
|
120066
|
120067
|
120068
|
120069
|
120070
|
120071
|
120072
|
120073
|
120074
|
120075
|
120076
|
121771
|
121772
|
121773
|
121774
|
121775
|
121776
|
121777
|
121778
|
121779
|
121780
|
121781
|
121782
|
121783
|
121785
|
121786
|
121787
|
121788
|
121789
|
121790
|
121791
|
121792
|
124286
|
124287
|
124288
|
124289
|
124290
|
124291
|
124292
|
124293
|
124294
|
124295
|
124296
|
124297
|
124298
|
124299
|
124300
|
124301
|
124302
|
124303
|
124304
|
124305
|
124306
|
124307
|
124321
|
128734
|
128735
|
128736
|
128737
|
128738
|
128739
|
128740
|
128741
|
128742
|
128743
|
128744
|
128745
|
128746
|
128747
|
128748
|
128749
|
128750
|
128751
|
128752
|
128753
|
131676
|
131677
|
131678
|
131679
|
131680
|
131681
|
131682
|
131683
|
131684
|
131685
|
131686
|
131687
|
131688
|
131689
|
131690
|
131691
|
131692
|
131693
|
131694
|
131695
|
131696
|
131697
|
132483
|
132484
|
132486
|
132917
|
134375
|
134376
|
134377
|
139135
|
139136
|
139137
|
139138
|
139139
|
139140
|
139141
|
139142
|
139143
|
139144
|
139145
|
139146
|
139147
|
139148
|
139149
|
139150
|
139151
|
139152
|
139153
|
139154
|
139155
|
139156
|
139157
|
139158
|
139159
|
139160
|
139161
|
139162
|
139163
|
143527
|
143529
|
143530
|
143531
|
143532
|
143533
|
143534
|
143535
|
143536
|
143537
|
143538
|
143539
|
143540
|
143541
|
143542
|
143543
|
143544
|
143545
|
143546
|
143547
|
143548
|
143549
|
143550
|
143551
|
143552
|
143553
|
143554
|
143555
|
143556
|
145286
|
145287
|
145288
|
145289
|
145290
|
145291
|
145292
|
145293
|
145482
|
145483
|
145484
|
145485
|
145486
|
145487
|
145488
|
145489
|
145809
|
145810
|
145811
|
145812
|
145813
|
145814
|
145815
|
145816
|
145887
|
145888
|
145889
|
145890
|
145891
|
145892
|
145893
|
145894
|
145895
|
145896
|
145951
|
145952
|
145953
|
145954
|
145955