Attachment 124365 Details for Bug 28929 – Bug 28929: Prevent flags to be sent during patron's edition

[patch] Bug 28929: Prevent flags to be sent during patron's edition

Bug-28929-Prevent-flags-to-be-sent-during-patrons-.patch (text/plain), 1.50 KB, created by Nick Clemens (kidclamp) on 2021-09-01 13:38:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-09-01 13:38:43 UTC

Size: 1.50 KB

patch

obsolete

>From b74e4e79dfeabb700e23d187b4a18ef33347b4a0 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 31 Aug 2021 15:55:15 +0200
>Subject: [PATCH] Bug 28929: Prevent flags to be sent during patron's edition
>
>* selfreg and selfmod for OPAC
>* patron's edition on staff
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Tested OPAC and staff side. Prevents mangling flags column.
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> members/memberentry.pl   | 1 +
> opac/opac-memberentry.pl | 1 +
> 2 files changed, 2 insertions(+)
>
>diff --git a/members/memberentry.pl b/members/memberentry.pl
>index 5844b9c3f9..c9460583af 100755
>--- a/members/memberentry.pl
>+++ b/members/memberentry.pl
>@@ -215,6 +215,7 @@ if ( $op eq 'insert' || $op eq 'modify' || $op eq 'save' || $op eq 'duplicate' )
> # remove keys from %newdata that is not part of patron's attributes
> {
>     my @keys_to_delete = (
>+        qr/^flags$/,
>         qr/^BorrowerMandatoryField$/,
>         qr/^category_type$/,
>         qr/^check_member$/,
>diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl
>index 8945cc339b..c940a6e1af 100755
>--- a/opac/opac-memberentry.pl
>+++ b/opac/opac-memberentry.pl
>@@ -522,6 +522,7 @@ sub ParseCgiForBorrower {
>     # Replace checkbox 'agreed' by datetime in gdpr_proc_consent
>     $borrower{gdpr_proc_consent} = dt_from_string if  $borrower{gdpr_proc_consent} && $borrower{gdpr_proc_consent} eq 'agreed';
> 
>+    delete $borrower{flags};
>     return %borrower;
> }
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28929: 124308 | 124310 | 124315 | 124316 | 124317 | 124323 | 124325 | 124364 | 124365 | 124366 | 124405 | 124406 | 124407 | 124683 | 124684 | 124685