Bugzilla – Attachment 12437 Details for
Bug 8742
Example uses perl 5.8 in Makefile.PL
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 8742 - Example uses perl 5.8 in Makefile.PL
Bug-8742---Example-uses-perl-58-in-MakefilePL.patch (text/plain), 1.77 KB, created by
Kyle M Hall (khall)
on 2012-09-21 14:57:43 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 8742 - Example uses perl 5.8 in Makefile.PL
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2012-09-21 14:57:43 UTC
Size:
1.77 KB
patch
obsolete
>From e1e0a6dd151ba5cbc7788d8223897fbde1569402 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Wed, 12 Sep 2012 01:25:59 +0800 >Subject: [PATCH] Bug 8742 - Example uses perl 5.8 in Makefile.PL >Content-Type: text/plain; charset="utf-8" > >Changed hardcoded path for a programmatic one. Basing it on: > grep /\/usr\/share\/perl\//, @INC; >And doing a: > push @version, ('/usr/share/perl/5.10') if !$version[0]; >For a reasonable default otherwise. No more references to > /usr/share/perl/5.8 >hardcoded into the output. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > Makefile.PL | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > >diff --git a/Makefile.PL b/Makefile.PL >index 46a3524..b6ca640 100644 >--- a/Makefile.PL >+++ b/Makefile.PL >@@ -1358,6 +1358,8 @@ sub _add_destdir { > sub display_configuration { > my $config = shift; > my $dirmap = shift; >+ my @version = grep /\/usr\/share\/perl\//, @INC; >+ push @version, ('/usr/share/perl/5.10') if !$version[0]; > print "\n\nKoha will be installed with the following configuration parameters:\n\n"; > foreach my $key (sort keys %$config) { > print sprintf("%-25.25s%s\n", $key, $config->{$key}); >@@ -1370,7 +1372,7 @@ sub display_configuration { > print "\n\nTo change any configuration setting, please run\n"; > print "perl Makefile.PL again. To override one of the target\n"; > print "directories, you can do so on the command line like this:\n"; >- print "\nperl Makefile.PL PERL_MODULE_DIR=/usr/share/perl/5.8\n\n"; >+ print "\nperl Makefile.PL PERL_MODULE_DIR=$version[0]\n\n"; > print "You can also set different default values for parameters\n"; > print "or override directory locations by using environment variables.\n"; > print "\nFor example:\n\n"; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8742
:
12079
|
12143
| 12437