Attachment 124506 Details for Bug 28529 – Bug 28529: Unit tests

[patch] Bug 28529: Unit tests

Bug-28529-Unit-tests.patch (text/plain), 6.83 KB, created by Tomás Cohen Arazi (tcohen) on 2021-09-03 19:51:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2021-09-03 19:51:47 UTC

Size: 6.83 KB

patch

obsolete

>From 9c8df45aa57c4daabd254ac0251938c42b157194 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 3 Sep 2021 16:47:14 -0300
>Subject: [PATCH] Bug 28529: Unit tests
>
>---
> t/db_dependent/Reserves.t | 185 +++++++++++++++++++++++++++++++++++++-
> 1 file changed, 184 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t
>index e748f115f4..94e8802282 100755
>--- a/t/db_dependent/Reserves.t
>+++ b/t/db_dependent/Reserves.t
>@@ -17,7 +17,7 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 68;
>+use Test::More tests => 70;
> use Test::MockModule;
> use Test::Warn;
> 
>@@ -1362,3 +1362,186 @@ sub place_item_hold {
> 
> # we reached the finish
> $schema->storage->txn_rollback();
>+
>+subtest 'CanBookBeReserved() tests' => sub {
>+
>+    plan tests => 4;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $library = $builder->build_object(
>+        { class => 'Koha::Libraries', value => { pickup_location => 1 } } );
>+    my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
>+    my $itype  = $builder->build_object( { class => 'Koha::ItemTypes' } );
>+
>+    my $biblio = $builder->build_sample_biblio();
>+    my $item_1 = $builder->build_sample_item(
>+        { biblionumber => $biblio->id, itype => $itype->id } );
>+    my $item_2 = $builder->build_sample_item(
>+        { biblionumber => $biblio->id, itype => $itype->id } );
>+
>+    Koha::CirculationRules->delete;
>+    Koha::CirculationRules->set_rules(
>+        {
>+            branchcode   => undef,
>+            categorycode => undef,
>+            itemtype     => undef,
>+            rules        => {
>+                holds_per_record => 100,
>+            }
>+        }
>+    );
>+    Koha::CirculationRules->set_rules(
>+        {
>+            branchcode   => undef,
>+            categorycode => undef,
>+            itemtype     => $itype->id,
>+            rules        => {
>+                reservesallowed => 2,
>+            }
>+        }
>+    );
>+
>+    C4::Reserves::AddReserve(
>+        {
>+            branchcode     => $library->id,
>+            borrowernumber => $patron->id,
>+            biblionumber   => $biblio->id,
>+            title          => $biblio->title,
>+            itemnumber     => $item_1->id
>+        }
>+    );
>+
>+    ## Limit on item type is 2, only one hold, success tests
>+
>+    t::lib::Mocks::mock_preference( 'BiblioHoldItemTypeUseForRules', 1 );
>+
>+    my $res = CanBookBeReserved( $patron->id, $biblio->id, $library->id,
>+        { itemtype => $itype->id } );
>+    is_deeply( $res, { status => 'OK' },
>+        'Holds on itemtype limit not reached' );
>+
>+    t::lib::Mocks::mock_preference( 'BiblioHoldItemTypeUseForRules', 0 );
>+
>+    $res = CanBookBeReserved( $patron->id, $biblio->id, $library->id,
>+        { itemtype => $itype->id } );
>+    is_deeply(
>+        $res,
>+        { status => 'OK' },
>+        'Holds on itemtype not considering biblio-level'
>+    );
>+
>+    # Add a second hold, biblio-level and item type-constrained
>+    C4::Reserves::AddReserve(
>+        {
>+            branchcode     => $library->id,
>+            borrowernumber => $patron->id,
>+            biblionumber   => $biblio->id,
>+            title          => $biblio->title,
>+            itemtype       => $itype->id,
>+        }
>+    );
>+
>+    ## Limit on item type is 2, two holds, one of them biblio-level/item type-constrained
>+
>+    t::lib::Mocks::mock_preference( 'BiblioHoldItemTypeUseForRules', 1 );
>+
>+    $res = CanBookBeReserved( $patron->id, $biblio->id, $library->id,
>+        { itemtype => $itype->id } );
>+    is_deeply( $res, { status => '' }, 'Holds on itemtype limit reached' );
>+
>+    t::lib::Mocks::mock_preference( 'BiblioHoldItemTypeUseForRules', 0 );
>+
>+    $res = CanBookBeReserved( $patron->id, $biblio->id, $library->id,
>+        { itemtype => $itype->id } );
>+    is_deeply(
>+        $res,
>+        { status => 'OK' },
>+        'Holds on itemtype not considering biblio-level'
>+    );
>+
>+    $schema->storage->txn_rollback;
>+};
>+
>+
>+subtest 'CanItemBeReserved() tests' => sub {
>+
>+    plan tests => 4;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $library = $builder->build_object({ class => 'Koha::Libraries', value => { pickup_location => 1 } });
>+    my $patron  = $builder->build_object({ class => 'Koha::Patrons' });
>+    my $itype = $builder->build_object({ class => 'Koha::ItemTypes' });
>+
>+    my $biblio = $builder->build_sample_biblio();
>+    my $item_1 = $builder->build_sample_item({ biblionumber => $biblio->id, itype => $itype->id });
>+    my $item_2 = $builder->build_sample_item({ biblionumber => $biblio->id, itype => $itype->id });
>+
>+    Koha::CirculationRules->delete;
>+    Koha::CirculationRules->set_rules(
>+        {   branchcode   => undef,
>+            categorycode => undef,
>+            itemtype     => undef,
>+            rules        => {
>+                holds_per_record => 100,
>+            }
>+        }
>+    );
>+    Koha::CirculationRules->set_rules(
>+        {   branchcode   => undef,
>+            categorycode => undef,
>+            itemtype     => $itype->id,
>+            rules        => {
>+                reservesallowed => 2,
>+            }
>+        }
>+    );
>+
>+    C4::Reserves::AddReserve(
>+        {
>+            branchcode     => $library->id,
>+            borrowernumber => $patron->id,
>+            biblionumber   => $biblio->id,
>+            title          => $biblio->title,
>+            itemnumber     => $item_1->id
>+        }
>+    );
>+
>+    ## Limit on item type is 2, only one hold, success tests
>+
>+    t::lib::Mocks::mock_preference( 'BiblioHoldItemTypeUseForRules', 1 );
>+
>+    my $res = CanItemBeReserved( $patron->id, $item_2->id, $library->id );
>+    is_deeply( $res, { status => 'OK' }, 'Holds on itemtype limit not reached' );
>+
>+    t::lib::Mocks::mock_preference( 'BiblioHoldItemTypeUseForRules', 0 );
>+
>+    $res = CanItemBeReserved( $patron->id, $item_2->id, $library->id );
>+    is_deeply( $res, { status => 'OK' }, 'Holds on itemtype not considering biblio-level' );
>+
>+    # Add a second hold, biblio-level and item type-constrained
>+    C4::Reserves::AddReserve(
>+        {
>+            branchcode     => $library->id,
>+            borrowernumber => $patron->id,
>+            biblionumber   => $biblio->id,
>+            title          => $biblio->title,
>+            itemtype       => $itype->id,
>+        }
>+    );
>+
>+    ## Limit on item type is 2, two holds, one of them biblio-level/item type-constrained
>+
>+    t::lib::Mocks::mock_preference( 'BiblioHoldItemTypeUseForRules', 1 );
>+
>+    $res = CanItemBeReserved( $patron->id, $item_2->id, $library->id );
>+    is_deeply( $res, { status => 'tooManyReserves', limit => 2 }, 'Holds on itemtype limit reached' );
>+
>+    t::lib::Mocks::mock_preference( 'BiblioHoldItemTypeUseForRules', 0 );
>+
>+    $res = CanItemBeReserved( $patron->id, $item_2->id, $library->id );
>+    is_deeply( $res, { status => 'OK' }, 'Holds on itemtype not considering biblio-level' );
>+
>+    $schema->storage->txn_rollback;
>+};
>-- 
>2.33.0

Actions: View | Diff | Splinter Review

Attachments on bug 28529: 124505 | 124506 | 124507 | 134557 | 134558 | 134559 | 134562 | 134790 | 134791 | 134792 | 134809 | 134810 | 134811 | 134837 | 134838 | 134839 | 134991 | 134992 | 134993 | 135044 | 135045 | 137964 | 137965