Bugzilla – Attachment 124513 Details for
Bug 10265
8xx serial added entries need spaces and punctuation in XSLT display
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10265: Keep punctuation for 8xx series added entry fields (MARC21)
Bug-10265-Keep-punctuation-for-8xx-series-added-en.patch (text/plain), 6.05 KB, created by
Joonas Kylmälä
on 2021-09-05 12:16:18 UTC
(
hide
)
Description:
Bug 10265: Keep punctuation for 8xx series added entry fields (MARC21)
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2021-09-05 12:16:18 UTC
Size:
6.05 KB
patch
obsolete
>From bf9b6b2b2579a5581d6e829c36fd9bdc58fdd899 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sun, 22 Aug 2021 03:29:47 +0000 >Subject: [PATCH] Bug 10265: Keep punctuation for 8xx series added entry fields > (MARC21) >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >At the moment the punctuation entered for $n $p and is >removed in the part template, which leads to displaying the subfields >without any punctuation and spaces in between. > >To test: >- Catalog records with various combinations of 8xx series added > entry fields. Subfield a, t, n, p and v are the most important. >- Verify the display in OPAC and staff is not great. >- Apply the patch. >- Verify the display in OPAC and staff is improved. > >For examples see: >https://www.loc.gov/marc/bibliographic/bd80x83x.html > >Important note: At the moment 8xx series added entry fields will only display, when >there is also a 490 ind. 1 = 1 field present. > >Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> >--- > .../prog/en/xslt/MARC21slimUtils.xsl | 16 ++++++++-------- > .../bootstrap/en/xslt/MARC21slimUtils.xsl | 18 +++++++++--------- > 2 files changed, 17 insertions(+), 17 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl >index 1916a711dd..c9678499f0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl >+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl >@@ -495,9 +495,9 @@ > </xsl:with-param> > </xsl:call-template> > </a> >- <xsl:call-template name="part"/> > </xsl:otherwise> > </xsl:choose> >+ <xsl:call-template name="part"/> > <xsl:text> ; </xsl:text> > <xsl:value-of select="marc:subfield[@code='v']" /> > <xsl:choose><xsl:when test="position()=last()"><xsl:text></xsl:text></xsl:when><xsl:otherwise><span class="separator"> | </span></xsl:otherwise></xsl:choose> >@@ -537,9 +537,9 @@ > </xsl:with-param> > </xsl:call-template> > </a> >- <xsl:call-template name="part"/> > </xsl:otherwise> > </xsl:choose> >+ <xsl:call-template name="part"/> > <xsl:if test="marc:subfield[@code='v']"> > <xsl:text> ; </xsl:text><xsl:value-of select="marc:subfield[@code='v']" /> > </xsl:if> >@@ -566,15 +566,15 @@ > <xsl:with-param name="afterCodes">fghkdlmor</xsl:with-param> > </xsl:call-template> > </xsl:variable> >+ <xsl:if test="$partNumber != '' or $partName != ''" > >+ <xsl:text>. </xsl:text> >+ </xsl:if> > <xsl:if test="string-length(normalize-space($partNumber))"> >- <xsl:call-template name="chopPunctuation"> >- <xsl:with-param name="chopString" select="$partNumber"/> >- </xsl:call-template> >+ <xsl:value-of select="$partNumber" /> > </xsl:if> >+ <xsl:if test="$partNumber != ''"><xsl:text> </xsl:text></xsl:if> > <xsl:if test="string-length(normalize-space($partName))"> >- <xsl:call-template name="chopPunctuation"> >- <xsl:with-param name="chopString" select="$partName"/> >- </xsl:call-template> >+ <xsl:value-of select="$partName" /> > </xsl:if> > </xsl:template> > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl >index 13e70d0ee8..4e918ea174 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl >@@ -459,10 +459,10 @@ > </xsl:with-param> > </xsl:call-template> > </a> >- <xsl:call-template name="part"/> > </xsl:otherwise> > </xsl:choose> >- <xsl:text>: </xsl:text> >+ <xsl:call-template name="part"/> >+ <xsl:text> ; </xsl:text> > <xsl:value-of select="marc:subfield[@code='v']" /> > <xsl:choose><xsl:when test="position()=last()"><xsl:text></xsl:text></xsl:when><xsl:otherwise><span class="separator"> | </span></xsl:otherwise></xsl:choose> > </xsl:for-each> >@@ -501,9 +501,9 @@ > </xsl:with-param> > </xsl:call-template> > </a> >- <xsl:call-template name="part"/> > </xsl:otherwise> > </xsl:choose> >+ <xsl:call-template name="part"/> > <xsl:if test="marc:subfield[@code='v']"> > <xsl:text> ; </xsl:text><xsl:value-of select="marc:subfield[@code='v']" /> > </xsl:if> >@@ -530,15 +530,15 @@ > <xsl:with-param name="afterCodes">fghkdlmor</xsl:with-param> > </xsl:call-template> > </xsl:variable> >+ <xsl:if test="$partNumber != '' or $partName != ''" > >+ <xsl:text>. </xsl:text> >+ </xsl:if> > <xsl:if test="string-length(normalize-space($partNumber))"> >- <xsl:call-template name="chopPunctuation"> >- <xsl:with-param name="chopString" select="$partNumber"/> >- </xsl:call-template> >+ <xsl:value-of select="$partNumber" /> > </xsl:if> >+ <xsl:if test="$partNumber != ''"><xsl:text> </xsl:text></xsl:if> > <xsl:if test="string-length(normalize-space($partName))"> >- <xsl:call-template name="chopPunctuation"> >- <xsl:with-param name="chopString" select="$partName"/> >- </xsl:call-template> >+ <xsl:value-of select="$partName" /> > </xsl:if> > </xsl:template> > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10265
:
18179
|
18180
|
18239
|
124060
|
124129
| 124513 |
124514