Attachment 124522 Details for Bug 28936 – Bug 28936: Add sort1/sort2 to borrowers.json

[patch] Bug 28936: Add sort1/sort2 to borrowers.json

0001-Bug-28936-Add-sort1-sort2-to-borrowers.json.patch (text/plain), 3.72 KB, created by Emmi Takkinen on 2021-09-06 06:02:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emmi Takkinen

Created: 2021-09-06 06:02:52 UTC

Size: 3.72 KB

patch

obsolete

>From 73f1e78a66fdec3962a2bcd829439e008fef7f9c Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Wed, 1 Sep 2021 16:24:52 +0000
>Subject: [PATCH] Bug 28936: Add sort1/sort2 to borrowers.json
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>To Test:
>1. Check the BorrowerMandatoryField and BorrowerUnwantedField system preferences, sort1 and sort2 cannot be hidden or required
>2. Apply patch
>3. Check the BorrowerMandatoryField and BorrowerUnwantedField system preferences again, you should see sort1 and sort2
>4. Since sort1 and sort2 are now added to borrowers.json we must also check the system preferences PatronQuickAddFields & PatronDuplicateMatchingAddFields
>5. They should both now include sort1 and sort2, check to make sure they work with these two system preferences
>6. Look at the system preferences PatronSelfRegistrationBorrowerMandatoryField, PatronSelfRegistrationBorrowerUnwantedField, and PatronSelfModificationBorrowerUnwantedField
>7. sort1 and sort2 should be disabled in these OPAC system preferences
>
>This patch does not attempt to add sort1 or sort2 to the self reg or borrower mod pages. If they should be added, which I am not sure they should, we should do so in a seperate bug
>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <joonas.kylmala@iki.fi>
>Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
>---
> .../prog/en/modules/admin/preferences/borrowers.json          | 4 +++-
> .../intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 4 +++-
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/borrowers.json b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/borrowers.json
>index 1a3f77e051..23140978f0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/borrowers.json
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/borrowers.json
>@@ -52,5 +52,7 @@
>     "altcontactcountry": "altcontactcountry",
>     "altcontactphone": "altcontactphone",
>     "smsalertnumber": "smsalertnumber",
>-    "primary_contact_method": "primary_contact_method"
>+    "primary_contact_method": "primary_contact_method",
>+    "sort1": "sort1",
>+    "sort2": "sort2"
> }
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>index 5d8e9cabd5..b91308e402 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>@@ -828,17 +828,19 @@ OPAC:
>             - pref: PatronSelfRegistrationBorrowerMandatoryField
>               type: modalselect
>               source: borrowers
>+              exclusions: sort1|sort2
>         -
>             - "The following <a href='http://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a> will not appear on the patron self-registration screen:"
>             - pref: PatronSelfRegistrationBorrowerUnwantedField
>               type: modalselect
>               source: borrowers
>-              exclusions: branchcode
>+              exclusions: branchcode|sort1|sort2
>         -
>             - "The following <a href='http://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a> will not appear on the patron self-modification screen:"
>             - pref: PatronSelfModificationBorrowerUnwantedField
>               type: modalselect
>               source: borrowers
>+              exclusions: sort1|sort2
>         -
>             - "Display the following additional instructions for patrons who self register via the OPAC ( HTML is allowed ):"
>             - pref: PatronSelfRegistrationAdditionalInstructions
>-- 
>2.25.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 28936: 124413 | 124516 | 124522