Attachment 124693 Details for Bug 28772 – Bug 28772: Do not hash secrets twice

[patch] Bug 28772: Do not hash secrets twice

Bug-28772-Do-not-hash-secrets-twice.patch (text/plain), 1.13 KB, created by Tomás Cohen Arazi (tcohen) on 2021-09-09 11:54:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2021-09-09 11:54:32 UTC

Size: 1.13 KB

patch

obsolete

>From c37c069cabd8d78505b67ed07463eab99ad2b6c4 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 9 Sep 2021 08:51:02 -0300
>Subject: [PATCH] Bug 28772: Do not hash secrets twice
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> installer/data/mysql/atomicupdate/bug_28772_api_keys.pl | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_28772_api_keys.pl b/installer/data/mysql/atomicupdate/bug_28772_api_keys.pl
>index 1e38409018..2baf5bf788 100755
>--- a/installer/data/mysql/atomicupdate/bug_28772_api_keys.pl
>+++ b/installer/data/mysql/atomicupdate/bug_28772_api_keys.pl
>@@ -25,8 +25,10 @@ return {
>         });
> 
>         foreach my $api_key (@$results) {
>-            my $digest = Koha::AuthUtils::hash_password( $api_key->{secret} );
>-            $sth->execute( $digest, $api_key->{client_id} );
>+            unless ( $api_key->{secret} =~ m/^\$2a\$08\$/ ) {
>+                my $digest = Koha::AuthUtils::hash_password( $api_key->{secret} );
>+                $sth->execute( $digest, $api_key->{client_id} );
>+            }
>         }
>     },
> }
>-- 
>2.33.0

Actions: View | Diff | Splinter Review

Attachments on bug 28772: 124195 | 124247 | 124248 | 124249 | 124250 | 124251 | 124487 | 124488 | 124489 | 124490 | 124491 | 124691 | 124692 | 124693 | 124694 | 124695 | 124696 | 124697 | 124698 | 124699 | 124700 | 124701 | 124702 | 124703 | 124704 | 124705 | 124727 | 125088 | 125112 | 125116 | 125118 | 125128