Attachment 124698 Details for Bug 28772 – Bug 28772: Add a warning about hash_password usage in updatedatabase.pl

[patch] Bug 28772: Add a warning about hash_password usage in updatedatabase.pl

Bug-28772-Add-a-warning-about-hashpassword-usage-i.patch (text/plain), 1.28 KB, created by Marcel de Rooy on 2021-09-09 12:47:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2021-09-09 12:47:01 UTC

Size: 1.28 KB

patch

obsolete

>From 34f967ba6e6f2d40898ad419df29815023b6aa5c Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 30 Aug 2021 11:08:57 -0300
>Subject: [PATCH] Bug 28772: Add a warning about hash_password usage in
> updatedatabase.pl
>Content-Type: text/plain; charset=utf-8
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> Koha/AuthUtils.pm | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/Koha/AuthUtils.pm b/Koha/AuthUtils.pm
>index 49d2723c54..8345f50a5f 100644
>--- a/Koha/AuthUtils.pm
>+++ b/Koha/AuthUtils.pm
>@@ -54,9 +54,15 @@ user passwords.
> 
>     my $hash = Koha::AuthUtils::hash_password($password, $settings);
> 
>+Hash I<$password> using Bcrypt. Accepts an extra I<$settings> parameter for salt.
>+If I<$settings> is not passed, a new salt is generated.
>+
>+WARNING: If this method implementation is changed in the future, as of
>+bug 28772 there's at least one DBRev that uses this code and should
>+be taken care of.
>+
> =cut
> 
>-# Using Bcrypt method for hashing. This can be changed to something else in future, if needed.
> sub hash_password {
>     my $password = shift;
>     $password = Encode::encode( 'UTF-8', $password )
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28772: 124195 | 124247 | 124248 | 124249 | 124250 | 124251 | 124487 | 124488 | 124489 | 124490 | 124491 | 124691 | 124692 | 124693 | 124694 | 124695 | 124696 | 124697 | 124698 | 124699 | 124700 | 124701 | 124702 | 124703 | 124704 | 124705 | 124727 | 125088 | 125112 | 125116 | 125118 | 125128