Bugzilla – Attachment 124700 Details for
Bug 28772
Any user that can work with reports can see API keys of any other user
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28722: Regression tests
Bug-28722-Regression-tests.patch (text/plain), 1.75 KB, created by
Marcel de Rooy
on 2021-09-09 12:47:10 UTC
(
hide
)
Description:
Bug 28722: Regression tests
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2021-09-09 12:47:10 UTC
Size:
1.75 KB
patch
obsolete
>From 9fcc5aede8b18883e82cdabf8e91336a212f0692 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 9 Sep 2021 08:23:48 -0300 >Subject: [PATCH] Bug 28722: Regression tests >Content-Type: text/plain; charset=utf-8 > >To test: >1. Apply this patch >2. Run: > $ kshell > k$ prove tt/db_dependent/api/v1/oauth.t >=> FAIL: Tests fail! > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >https://bugs.koha-community.org/show_bug.cgi?id=28772 > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/api/v1/oauth.t | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/api/v1/oauth.t b/t/db_dependent/api/v1/oauth.t >index 4e464d53f2..c9381796e8 100755 >--- a/t/db_dependent/api/v1/oauth.t >+++ b/t/db_dependent/api/v1/oauth.t >@@ -97,7 +97,7 @@ subtest 'Net::OAuth2::AuthorizationServer missing tests' => sub { > my $form_data = { > grant_type => 'client_credentials', > client_id => $api_key->client_id, >- client_secret => $api_key->secret >+ client_secret => $api_key->plain_text_secret > }; > > $t->post_ok( '/api/v1/oauth/token', form => $form_data )->status_is(200) >@@ -138,7 +138,7 @@ sub run_oauth_tests { > > my $formData; > my $client_id = $api_key->client_id; >- my $client_secret = $api_key->secret; >+ my $client_secret = $api_key->plain_text_secret; > > if ( $test_case eq 'header' ) { > >@@ -154,7 +154,7 @@ sub run_oauth_tests { > $formData = { > grant_type => 'client_credentials', > client_id => $api_key->client_id, >- client_secret => $api_key->secret >+ client_secret => $api_key->plain_text_secret > }; > > $t->post_ok('/api/v1/oauth/token', form => $formData) >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28772
:
124195
|
124247
|
124248
|
124249
|
124250
|
124251
|
124487
|
124488
|
124489
|
124490
|
124491
|
124691
|
124692
|
124693
|
124694
|
124695
|
124696
|
124697
|
124698
|
124699
| 124700 |
124701
|
124702
|
124703
|
124704
|
124705
|
124727
|
125088
|
125112
|
125116
|
125118
|
125128